fix: describe fetch_notes pagination as seq-based - #156
Open
dumanoglu1 wants to merge 1 commit into
Open
dumanoglu1 wants to merge 1 commit into
dumanoglu1 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
seqcursor.fetch_notes()bullet to remove the stale timestamp-based pagination wording.Why
The current implementation paginates with SQLite
seqvalues and only treats timestamp-sized cursors as legacy values. The old wording could make clients infer timestamp-based cursor semantics instead of persisting the server-returned cursor.Fixes #155
Validation
git diff --checkrg -n "currently a timestamp|pagination based on a timestamp|node timestamps notes" docs\src\index.md crates\node\README.mdmdbook build docsusing mdBook 0.4.52 with the configured preprocessors/backends installedNote: linkcheck reports existing warnings for GitHub-style alert markers such as
[!IMPORTANT]; the build exits successfully.