Conversation
… setup
### Description
This PR addresses insecure default credentials and documentation drift within the `note-transport-service` repository's monitoring stack.
**Vulnerabilities & Security Defects Remediated:**
* **Default Credential / Insecure Deployment Configuration (`bin/node/docker/docker-compose.yml`):** The supported monitoring compose stack previously hardcoded the Grafana administrator password (`GF_SECURITY_ADMIN_PASSWORD=admin`). This has been replaced with strict environment variable interpolation (`${GRAFANA_ADMIN_PASSWORD:?...}`). The stack now securely fails closed upon startup if an administrator password is not explicitly provided, preventing deployments with publicly known credentials.
* **Documentation Drift After Security Remediation (`docs/src/operator/installation.md`):** The Docker setup instructions in the operator guide have been updated to align with the new security constraints. Operators are now instructed to generate and export a strong `GRAFANA_ADMIN_PASSWORD` before starting the node. The documentation explicitly explains the fail-closed safety mechanism and no longer publishes a default password.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses insecure default credentials and documentation drift within the
note-transport-servicerepository's monitoring stack.Vulnerabilities & Security Defects Remediated:
bin/node/docker/docker-compose.yml): The supported monitoring compose stack previously hardcoded the Grafana administrator password (GF_SECURITY_ADMIN_PASSWORD=admin). This has been replaced with strict environment variable interpolation (${GRAFANA_ADMIN_PASSWORD:?...}). The stack now securely fails closed upon startup if an administrator password is not explicitly provided, preventing deployments with publicly known credentials.docs/src/operator/installation.md): The Docker setup instructions in the operator guide have been updated to align with the new security constraints. Operators are now instructed to generate and export a strongGRAFANA_ADMIN_PASSWORDbefore starting the node. The documentation explicitly explains the fail-closed safety mechanism and no longer publishes a default password.