fix: replace unwrap() with ? in AccountWitness::new() TryFrom impl

[bigeez]

Summary

Replaces 4 unwrap()/expect() calls in production code with proper error propagation using ? and map_err().

Changes

1. crates/rust-client/src/rpc/domain/account.rs

AccountWitness::new().unwrap() inside a TryFrom impl where everything else uses ?. Applied the same .map_err(|err| RpcError::InvalidResponse(format!("{err}")))? pattern already used in the same file.

2. crates/sqlite-store/src/chain_data.rs

NonZeroUsize::new().unwrap() and usize::try_from().expect() when parsing DB data. A zero or overflow value would panic inside a Result-returning function. Both now return StoreError::ParsingError.

3. crates/sqlite-store/src/account/accounts.rs

nonces.last().unwrap() with no empty-slice guard in undo_account_nonces(). Now returns StoreError::ParsingError if nonces is empty.

4. crates/rust-client/src/transaction/request/mod.rs

.expect() on try_into() inside build_input_notes() which returns Result. Added NoteRecordError variant to TransactionRequestError and propagated with ?.

Result

• 4 files changed
• All panics in Result-returning functions replaced with proper error propagation
• No behavior changes in the happy path

[bigeez]

can you retry the merge?

[igamigo]

Hello @bigeez, thanks for the PR. Can you rebase this to the latest next and remove the unrelated commits from this PR's history? It's not really reviewable as-is.

[bigeez]

Hi @igamigo, done!
Rebased onto the latest next and the branch now contains only the single relevant commit.

Thanks for the guidance!

[igamigo]

I think this might be missing some changes. The PR description mentions four different changes but the diff shows one.

[bigeez]

the 3 other fixes were dropped during the rebase cleanup, I've added them back as seperate commits

[igamigo]

Let's just keep the AccountWitness change. The other ones express invariants that shouldn't be broken and not errors that make sense for the user to react to in any way

[igamigo]

Let's add a safety comment to this expressing while the unwrap() was safe

[bigeez]

I've dropped the chain_data and request/mod changes, and replaced the accounts.rs unwrap change with a safety comment explaining the invariant instead. The PR now has just two commits:

1. The AccountWitness::new() fix in account.rs
2. A safety comment on nonces.last().unwrap() in accounts.rs