Open
Conversation
04990fe to
70213bd
Compare
70213bd to
31c99c3
Compare
igamigo
reviewed
Apr 1, 2026
0903ee6 to
10eec01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adapts the client to the changes introduced in the
SyncNotesendpoints 0xMiden/node#1843.Before:
sync_notesreturned a single block per call. The client sync state was driven by thesync_notes. For each matched block,sync_chain_mmrandsync_transactionswas used.Now, the sync state works like so:
get_block_header_by_number: single call to discover the chain tip.sync_chain_mmr: single call to get the full MMR delta to the chain tip.sync_notes: loop get the note updates for the block range (may be paginated).sync_transactions: single call to get all transaction updates.Applying the sync result:
partial_mmr.track()using the MMR auth path from theresponse.