security: mitigate BatchSign DoS with limits and deduplication#32
Open
EFCCWEB3 wants to merge 1 commit into0gfoundation:mainfrom
Open
security: mitigate BatchSign DoS with limits and deduplication#32EFCCWEB3 wants to merge 1 commit into0gfoundation:mainfrom
EFCCWEB3 wants to merge 1 commit into0gfoundation:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a resource exhaustion vulnerability in the
batch_signRPC endpoint.Fixes
MAX_BATCH_SIZEof 100 to prevent massive gRPC messages from overwhelming the node with expensive KZG verifications.HashSetto ensure eachstorage_rootin a batch is unique, preventing an attacker from using a single on-chain upload to trigger redundant CPU-heavy operations.Closes #31