chore: consistent use of std::ranges::for_each (acts-project#4319)

Move consistently from `std::for_each` to `std::ranges::for_each`.

Will reduce SonarCloud issues,.

Author: asalzburger

Core/include/Acts/Clusterization/Clusterization.ipp

@@ -12,6 +12,7 @@
 
 #include <algorithm>
 #include <array>
+#include <ranges>
 #include <vector>
 
 #include <boost/pending/disjoint_sets.hpp>
@@ -89,7 +90,7 @@ template <std::size_t BufSize>
 struct ConnectionsBase {
   std::size_t nconn{0};
   std::array<Label, BufSize> buf;
-  ConnectionsBase() { std::fill(buf.begin(), buf.end(), NO_LABEL); }
+  ConnectionsBase() { std::ranges::fill(buf, NO_LABEL); }
 };
 
 template <std::size_t GridDim>

Core/include/Acts/Detector/DetectorVolume.hpp

@@ -586,8 +586,8 @@ struct IndexedSurfacesExtractor {
     // The extracted surfaces
     std::vector<const Surface*> eSurfaces;
     eSurfaces.reserve(indices.size());
-    std::for_each(indices.begin(), indices.end(),
-                  [&](const auto& i) { eSurfaces.push_back(surfaces[i]); });
+    std::ranges::for_each(
+        indices, [&](const auto& i) { eSurfaces.push_back(surfaces[i]); });
     return eSurfaces;
   }
 };
@@ -634,8 +634,8 @@ struct IndexedSubVolumesExtractor {
     // The extracted volumes
     std::vector<const DetectorVolume*> eVolumes;
     eVolumes.reserve(indices.size());
-    std::for_each(indices.begin(), indices.end(),
-                  [&](const auto& i) { eVolumes.push_back(volumes[i]); });
+    std::ranges::for_each(
+        indices, [&](const auto& i) { eVolumes.push_back(volumes[i]); });
     return eVolumes;
   }
 };

Core/include/Acts/Detector/GeometryIdMapper.hpp

@@ -15,6 +15,7 @@
 #include "Acts/Surfaces/Surface.hpp"
 
 #include <map>
+#include <ranges>
 
 namespace Acts::Experimental {
 
@@ -85,16 +86,19 @@ class GeometryIdMapper final : public IGeometryIdGenerator {
     }
 
     // Portals
-    std::for_each(dVolume.portalPtrs().begin(), dVolume.portalPtrs().end(),
-                  [&](auto& portal) { assignGeometryId(cache, *portal); });
+    std::ranges::for_each(dVolume.portalPtrs(), [&](auto& portal) {
+      assignGeometryId(cache, *portal);
+    });
 
     // Surfaces
-    std::for_each(dVolume.surfacePtrs().begin(), dVolume.surfacePtrs().end(),
-                  [&](auto& surface) { assignGeometryId(cache, *surface); });
+    std::ranges::for_each(dVolume.surfacePtrs(), [&](auto& surface) {
+      assignGeometryId(cache, *surface);
+    });
 
     // Sub volumes
-    std::for_each(dVolume.volumePtrs().begin(), dVolume.volumePtrs().end(),
-                  [&](auto& volume) { assignGeometryId(cache, *volume); });
+    std::ranges::for_each(dVolume.volumePtrs(), [&](auto& volume) {
+      assignGeometryId(cache, *volume);
+    });
   }
 
   /// @brief Method for assigning a geometry id to a portal

Core/include/Acts/Detector/KdtSurfacesProvider.hpp

@@ -16,6 +16,7 @@
 #include "Acts/Utilities/KDTree.hpp"
 
 #include <array>
+#include <ranges>
 #include <stdexcept>
 #include <tuple>
 #include <vector>
@@ -90,8 +91,8 @@ class KdtSurfaces {
     // Strip the surfaces
     std::vector<std::shared_ptr<Surface>> surfacePtrs;
     auto surfaceQuery = m_kdt->rangeSearchWithKey(range);
-    std::for_each(surfaceQuery.begin(), surfaceQuery.end(),
-                  [&](auto& surf) { surfacePtrs.push_back(surf.second); });
+    std::ranges::for_each(
+        surfaceQuery, [&](auto& surf) { surfacePtrs.push_back(surf.second); });
     return surfacePtrs;
   }
 
@@ -150,7 +151,7 @@ class KdtSurfaces {
       std::transform(c.begin(), c.end(), q.begin(), c.begin(),
                      std::plus<double>());
     }
-    std::for_each(c.begin(), c.end(), [&](auto& v) { v *= weight; });
+    std::ranges::for_each(c, [&](auto& v) { v *= weight; });
     return c;
   }
 };

Core/include/Acts/Detector/detail/ReferenceGenerators.hpp

@@ -14,6 +14,7 @@
 #include "Acts/Surfaces/Surface.hpp"
 #include "Acts/Utilities/BinningData.hpp"
 
+#include <ranges>
 #include <vector>
 
 namespace Acts::Experimental::detail {
@@ -83,8 +84,7 @@ struct PolyhedronReferenceGenerator {
     // Add the barycenter if configured
     if constexpr (aBARY) {
       Vector3 bc(0., 0., 0.);
-      std::for_each(rPositions.begin(), rPositions.end(),
-                    [&](const auto& p) { bc += p; });
+      std::ranges::for_each(rPositions, [&](const auto& p) { bc += p; });
       bc *= 1. / rPositions.size();
       rPositions.push_back(bc);
     }

Core/include/Acts/Navigation/NavigationStateFillers.hpp

@@ -14,6 +14,7 @@
 #include "Acts/Surfaces/BoundaryTolerance.hpp"
 #include "Acts/Utilities/Intersection.hpp"
 
+#include <ranges>
 #include <vector>
 
 namespace Acts {
@@ -49,7 +50,7 @@ struct SurfacesFiller {
   /// @param surfaces the surfaces that are filled in
   inline static void fill(NavigationState& nState,
                           const std::vector<const Surface*>& surfaces) {
-    std::for_each(surfaces.begin(), surfaces.end(), [&](const auto& s) {
+    std::ranges::for_each(surfaces, [&](const auto& s) {
       nState.surfaceCandidates.push_back(NavigationState::SurfaceCandidate{
           ObjectIntersection<Surface>::invalid(), s, nullptr,
           nState.surfaceBoundaryTolerance});
@@ -66,7 +67,7 @@ struct PortalsFiller {
   /// @param portals the portals that are filled in
   inline static void fill(NavigationState& nState,
                           const std::vector<const Portal*>& portals) {
-    std::for_each(portals.begin(), portals.end(), [&](const auto& p) {
+    std::ranges::for_each(portals, [&](const auto& p) {
       nState.surfaceCandidates.push_back(NavigationState::SurfaceCandidate{
           ObjectIntersection<Surface>::invalid(), nullptr, p,
           BoundaryTolerance::None()});

Core/src/Detector/CuboidalContainerBuilder.cpp

@@ -18,6 +18,7 @@
 
 #include <algorithm>
 #include <ostream>
+#include <ranges>
 #include <stdexcept>
 #include <utility>
 
@@ -128,17 +129,16 @@ Acts::Experimental::CuboidalContainerBuilder::construct(
   std::vector<DetectorComponent::PortalContainer> containers;
   std::vector<std::shared_ptr<DetectorVolume>> rootVolumes;
   // Run through the builders
-  std::for_each(
-      m_cfg.builders.begin(), m_cfg.builders.end(), [&](const auto& builder) {
-        auto [cVolumes, cContainer, cRoots] = builder->construct(gctx);
-        atNavigationLevel = (atNavigationLevel && cVolumes.size() == 1u);
-        ACTS_VERBOSE("Number of volumes: " << cVolumes.size());
-        // Collect individual components, volumes, containers, roots
-        volumes.insert(volumes.end(), cVolumes.begin(), cVolumes.end());
-        containers.push_back(cContainer);
-        rootVolumes.insert(rootVolumes.end(), cRoots.volumes.begin(),
-                           cRoots.volumes.end());
-      });
+  std::ranges::for_each(m_cfg.builders, [&](const auto& builder) {
+    auto [cVolumes, cContainer, cRoots] = builder->construct(gctx);
+    atNavigationLevel = (atNavigationLevel && cVolumes.size() == 1u);
+    ACTS_VERBOSE("Number of volumes: " << cVolumes.size());
+    // Collect individual components, volumes, containers, roots
+    volumes.insert(volumes.end(), cVolumes.begin(), cVolumes.end());
+    containers.push_back(cContainer);
+    rootVolumes.insert(rootVolumes.end(), cRoots.volumes.begin(),
+                       cRoots.volumes.end());
+  });
   // Navigation level detected, connect volumes (cleaner and faster than
   // connect containers)
   if (atNavigationLevel) {
@@ -161,12 +161,12 @@ Acts::Experimental::CuboidalContainerBuilder::construct(
     ACTS_DEBUG("Assigning geometry ids to the detector");
     auto cache = m_cfg.geoIdGenerator->generateCache();
     if (m_cfg.geoIdReverseGen) {
-      std::for_each(rootVolumes.rbegin(), rootVolumes.rend(), [&](auto& v) {
+      std::ranges::for_each(rootVolumes, [&](auto& v) {
         m_cfg.geoIdGenerator->assignGeometryId(cache, *v);
         ACTS_VERBOSE("-> Assigning geometry id to volume " << v->name());
       });
     } else {
-      std::for_each(rootVolumes.begin(), rootVolumes.end(), [&](auto& v) {
+      std::ranges::for_each(rootVolumes, [&](auto& v) {
         m_cfg.geoIdGenerator->assignGeometryId(cache, *v);
         ACTS_VERBOSE("-> Assigning geometry id to volume " << v->name());
       });

Core/src/Detector/CylindricalContainerBuilder.cpp

@@ -20,6 +20,7 @@
 
 #include <algorithm>
 #include <ostream>
+#include <ranges>
 #include <stdexcept>
 #include <utility>
 
@@ -215,16 +216,15 @@ Acts::Experimental::CylindricalContainerBuilder::construct(
   std::vector<DetectorComponent::PortalContainer> containers;
   std::vector<std::shared_ptr<DetectorVolume>> rootVolumes;
   // Run through the builders
-  std::for_each(
-      m_cfg.builders.begin(), m_cfg.builders.end(), [&](const auto& builder) {
-        auto [cVolumes, cContainer, cRoots] = builder->construct(gctx);
-        atNavigationLevel = (atNavigationLevel && cVolumes.size() == 1u);
-        // Collect individual components, volumes, containers, roots
-        volumes.insert(volumes.end(), cVolumes.begin(), cVolumes.end());
-        containers.push_back(cContainer);
-        rootVolumes.insert(rootVolumes.end(), cRoots.volumes.begin(),
-                           cRoots.volumes.end());
-      });
+  std::ranges::for_each(m_cfg.builders, [&](const auto& builder) {
+    auto [cVolumes, cContainer, cRoots] = builder->construct(gctx);
+    atNavigationLevel = (atNavigationLevel && cVolumes.size() == 1u);
+    // Collect individual components, volumes, containers, roots
+    volumes.insert(volumes.end(), cVolumes.begin(), cVolumes.end());
+    containers.push_back(cContainer);
+    rootVolumes.insert(rootVolumes.end(), cRoots.volumes.begin(),
+                       cRoots.volumes.end());
+  });
   // Navigation level detected, connect volumes (cleaner and faster than
   // connect containers)
   if (atNavigationLevel) {
@@ -250,7 +250,7 @@ Acts::Experimental::CylindricalContainerBuilder::construct(
         ACTS_VERBOSE("-> Assigning geometry id to volume " << v->name());
       });
     } else {
-      std::for_each(rootVolumes.begin(), rootVolumes.end(), [&](auto& v) {
+      std::ranges::for_each(rootVolumes, [&](auto& v) {
         m_cfg.geoIdGenerator->assignGeometryId(cache, *v);
         ACTS_VERBOSE("-> Assigning geometry id to volume " << v->name());
       });

Core/src/Detector/DetectorBuilder.cpp

@@ -14,6 +14,7 @@
 #include "Acts/Material/IMaterialDecorator.hpp"
 #include "Acts/Navigation/DetectorVolumeFinders.hpp"
 
+#include <algorithm>
 #include <stdexcept>
 
 Acts::Experimental::DetectorBuilder::DetectorBuilder(
@@ -41,7 +42,7 @@ Acts::Experimental::DetectorBuilder::construct(
   if (m_cfg.geoIdGenerator != nullptr) {
     ACTS_DEBUG("Assigning geometry ids to the detector");
     auto cache = m_cfg.geoIdGenerator->generateCache();
-    std::for_each(roots.volumes.begin(), roots.volumes.end(), [&](auto& v) {
+    std::ranges::for_each(roots.volumes, [&](auto& v) {
       ACTS_VERBOSE("-> Assigning geometry id to volume " << v->name());
       m_cfg.geoIdGenerator->assignGeometryId(cache, *v);
     });
@@ -50,7 +51,7 @@ Acts::Experimental::DetectorBuilder::construct(
   // Decorate the volumes with material - Surface material only at this moment
   if (m_cfg.materialDecorator != nullptr) {
     ACTS_DEBUG("Decorating the detector with material");
-    std::for_each(volumes.begin(), volumes.end(), [&](auto& v) {
+    std::ranges::for_each(volumes, [&](auto& v) {
       // Assign to surfaces
       for (auto& sf : v->surfacePtrs()) {
         m_cfg.materialDecorator->decorate(*sf);

Core/src/Detector/GeometryIdGenerator.cpp

@@ -31,12 +31,14 @@ void Acts::Experimental::GeometryIdGenerator::assignGeometryId(
   }
 
   // Portals
-  std::for_each(dVolume.portalPtrs().begin(), dVolume.portalPtrs().end(),
-                [&](auto& portal) { assignGeometryId(cache, *portal); });
+  std::ranges::for_each(dVolume.portalPtrs(), [&](auto& portal) {
+    assignGeometryId(cache, *portal);
+  });
 
   // Surfaces
-  std::for_each(dVolume.surfacePtrs().begin(), dVolume.surfacePtrs().end(),
-                [&](auto& surface) { assignGeometryId(cache, *surface); });
+  std::ranges::for_each(dVolume.surfacePtrs(), [&](auto& surface) {
+    assignGeometryId(cache, *surface);
+  });
 
   if (m_cfg.resetSubCounters) {
     ccache.portalCount = 0u;
@@ -45,8 +47,9 @@ void Acts::Experimental::GeometryIdGenerator::assignGeometryId(
   }
 
   // Sub volumes
-  std::for_each(dVolume.volumePtrs().begin(), dVolume.volumePtrs().end(),
-                [&](auto& volume) { assignGeometryId(cache, *volume); });
+  std::ranges::for_each(dVolume.volumePtrs(), [&](auto& volume) {
+    assignGeometryId(cache, *volume);
+  });
 }
 
 void Acts::Experimental::GeometryIdGenerator::assignGeometryId(