-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving the style of tabs #347
Conversation
I am satisfied with how it looks now. I would appreciate if people could check how it looks on their system. I have not tested on mac and linux, so it would be especially good to get feedback for those. |
Tagging @boldar99 @y-richie-y for mac |
What's that horizontal line passing through the tabs? Also the tabs are centered on Mac for some reason. This makes the lack of a left tab border look a bit strange. |
Can you also check if the effects of hovering on the tab and the close button look decent? And can you also try tabs with the system's dark mode? |
Okay so we need more changes to make it work for Mac. Perhaps we can do this in person sometime? |
@RazinShaikh @boldar99 Do you think you will still do this thing? I'm wondering whether it makes sense to keep this PR open. |
I forgot about this PR. I don't have a mac so I can't try it. We can close it for now and then reopen it later at some point. |
Resolve #323