Fix: Inherit root font-size in SVG output #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@Amyuan23 thank you very much! I'm going to perform some tests using real demos because this part un code may produce unexpected side effects. |
Contributor
Author
|
@tinchox5 Thank you! Looking forward to your test results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Image elements with dimensions specified in rem units were not rendered at the correct size in the generated SVG. This occurred because the SVG did not inherit the document's root font-size, causing the browser to use the default 16px instead of the actual root font-size.
This fix ensures that all elements using rem units (images, text, borders, etc.) are rendered at the correct size, matching the original document's appearance.