-
Notifications
You must be signed in to change notification settings - Fork 349
Open
Labels
a-composeCompose box, autocomplete, attaching files/imagesCompose box, autocomplete, attaching files/imagesserver-10Things new in Zulip Server 10.0Things new in Zulip Server 10.0user feedbackThings users have specifically asked forThings users have specifically asked for
Milestone
Description
To reproduce:
- Connect to CZO or another realm with feature level 334+
- Enter a channel narrow
- Long-press a message; tap "Quote and reply"
- See the content input update with the quoted message
Expected: the topic input is automatically filled with the message's topic
Actual: the topic input remains blank
This looks like a regression from the recent "general chat" work. To check if the topic input was left empty, the quote-and-reply button checks the condition composeBoxController.topic.textNormalized == kNoTopicTopic. Before 769cc7d, that condition was a reliable test of whether the topic input was left empty. But it isn't reliable anymore; on recent servers, if the topic input is left empty, composeBoxController.topic.textNormalized will be the empty string.
PIG208 and gnprice
Metadata
Metadata
Assignees
Labels
a-composeCompose box, autocomplete, attaching files/imagesCompose box, autocomplete, attaching files/imagesserver-10Things new in Zulip Server 10.0Things new in Zulip Server 10.0user feedbackThings users have specifically asked forThings users have specifically asked for
Type
Projects
Status
No status