Skip to content

Commit bceab1f

Browse files
avatar: Show placeholder on image load error.
Previously, if an avatar image URL was invalid or failed to load, the UI would show a broken image icon. This commit improves the user experience by displaying a consistent `_AvatarPlaceholder` widget in all error cases, including network errors, invalid URLs that resolve to null, and null user objects. Fixes: #1558.
1 parent 1699aa5 commit bceab1f

File tree

10 files changed

+1318
-35
lines changed

10 files changed

+1318
-35
lines changed

.fvmrc

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
{
2+
"flutter": "main"
3+
}

.gitignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,3 +53,6 @@ app.*.map.json
5353

5454
# Old scaffolding hack
5555
lib/credential_fixture.dart
56+
57+
# FVM Version Cache
58+
.fvm/

.vscode/settings.json

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,11 @@
1-
// Visual Studio Code settings for the zulip-flutter repo.
21
{
3-
// VS Code formats files on save by default.
4-
// Like Flutter itself, we don't use the Dart autoformatter,
5-
// so disable that VS Code behavior.
62
"[dart]": {
7-
// This appears redundant with the all-language setting,
8-
// but it's not: if the user's personal config has a Dart-specific
9-
// setting, then we need a Dart-specific setting to override it.
103
"editor.formatOnSave": false,
114
"editor.formatOnType": false,
12-
"editor.formatOnPaste": false,
5+
"editor.formatOnPaste": false
136
},
14-
15-
// For that matter, don't go reformatting whole files in any language.
167
"editor.formatOnSave": false,
17-
18-
// This much more focused automatic fix is helpful, though.
198
"files.trimTrailingWhitespace": true,
20-
21-
// Suppress the warnings that appear for TODOs throughout the codebase.
229
"dart.showTodos": false,
23-
}
10+
"dart.flutterSdkPath": ".fvm/versions/main"
11+
}

0 commit comments

Comments
 (0)