Skip to content

Commit 6647a7f

Browse files
PIG208PIG208
committed
compose: Support save snippets
We sort the saved snippets by title to be consistent with the web implementation. A subtle nuance of having a compose box in a modal bottom sheet is that the message list page behind will shift when the keyboard is expanded, even though its compose box is not visible anyway. An UX improvement would be preserving the inputs on the saved snippet compose box after the user has navigated away. Fixes: #863
1 parent df0b4a7 commit 6647a7f

15 files changed

+1245
-0
lines changed

‎assets/l10n/app_en.arb‎

Lines changed: 48 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -385,6 +385,54 @@
385385
"@composeBoxAttachFromCameraTooltip": {
386386
"description": "Tooltip for compose box icon to attach an image from the camera to the message."
387387
},
388+
"composeBoxShowSavedSnippetsTooltip": "Show saved snippets",
389+
"@composeBoxShowSavedSnippetsTooltip": {
390+
"description": "Tooltip for compose box icon to show a list of saved snippets."
391+
},
392+
"noSavedSnippets": "No saved snippets",
393+
"@noSavedSnippets": {
394+
"description": "Text to show on the saved snippets bottom sheet when there are no saved snippets."
395+
},
396+
"savedSnippetsTitle": "Saved snippets",
397+
"@savedSnippetsTitle": {
398+
"description": "Title for the bottom sheet to display saved snippets."
399+
},
400+
"newSavedSnippetButton": "New",
401+
"@newSavedSnippetButton": {
402+
"description": "Label for adding a new saved snippet."
403+
},
404+
"newSavedSnippetTitle": "New snippet",
405+
"@newSavedSnippetTitle": {
406+
"description": "Title for the bottom sheet to add a new saved snippet."
407+
},
408+
"newSavedSnippetTitleHint": "Title",
409+
"@newSavedSnippetTitleHint": {
410+
"description": "Hint text for the title input when adding a new saved snippet."
411+
},
412+
"newSavedSnippetContentHint": "Content",
413+
"@newSavedSnippetContentHint": {
414+
"description": "Hint text for the content input when adding a new saved snippet."
415+
},
416+
"errorFailedToCreateSavedSnippetTitle": "Failed to create saved snippet",
417+
"@errorFailedToCreateSavedSnippetTitle": {
418+
"description": "Error title when the saved snippet failed to be created."
419+
},
420+
"savedSnippetTitleValidationErrorEmpty": "Title cannot be empty.",
421+
"@savedSnippetTitleValidationErrorEmpty": {
422+
"description": "Validation error message when the title of the saved snippet is empty."
423+
},
424+
"savedSnippetTitleValidationErrorTooLong": "Title length shouldn't be greater than 60 characters.",
425+
"@savedSnippetTitleValidationErrorTooLong": {
426+
"description": "Validation error message when the title of the saved snippet is too long."
427+
},
428+
"savedSnippetContentValidationErrorEmpty": "Content cannot be empty.",
429+
"@savedSnippetContentValidationErrorEmpty": {
430+
"description": "Validation error message when the content of the saved snippet is empty."
431+
},
432+
"savedSnippetContentValidationErrorTooLong": "Content length shouldn't be greater than 10000 characters.",
433+
"@savedSnippetContentValidationErrorTooLong": {
434+
"description": "Validation error message when the content of the saved snippet is too long."
435+
},
388436
"composeBoxGenericContentHint": "Type a message",
389437
"@composeBoxGenericContentHint": {
390438
"description": "Hint text for content input when sending a message."

‎lib/generated/l10n/zulip_localizations.dart‎

Lines changed: 72 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -640,6 +640,78 @@ abstract class ZulipLocalizations {
640640
/// **'Take a photo'**
641641
String get composeBoxAttachFromCameraTooltip;
642642

643+
/// Tooltip for compose box icon to show a list of saved snippets.
644+
///
645+
/// In en, this message translates to:
646+
/// **'Show saved snippets'**
647+
String get composeBoxShowSavedSnippetsTooltip;
648+
649+
/// Text to show on the saved snippets bottom sheet when there are no saved snippets.
650+
///
651+
/// In en, this message translates to:
652+
/// **'No saved snippets'**
653+
String get noSavedSnippets;
654+
655+
/// Title for the bottom sheet to display saved snippets.
656+
///
657+
/// In en, this message translates to:
658+
/// **'Saved snippets'**
659+
String get savedSnippetsTitle;
660+
661+
/// Label for adding a new saved snippet.
662+
///
663+
/// In en, this message translates to:
664+
/// **'New'**
665+
String get newSavedSnippetButton;
666+
667+
/// Title for the bottom sheet to add a new saved snippet.
668+
///
669+
/// In en, this message translates to:
670+
/// **'New snippet'**
671+
String get newSavedSnippetTitle;
672+
673+
/// Hint text for the title input when adding a new saved snippet.
674+
///
675+
/// In en, this message translates to:
676+
/// **'Title'**
677+
String get newSavedSnippetTitleHint;
678+
679+
/// Hint text for the content input when adding a new saved snippet.
680+
///
681+
/// In en, this message translates to:
682+
/// **'Content'**
683+
String get newSavedSnippetContentHint;
684+
685+
/// Error title when the saved snippet failed to be created.
686+
///
687+
/// In en, this message translates to:
688+
/// **'Failed to create saved snippet'**
689+
String get errorFailedToCreateSavedSnippetTitle;
690+
691+
/// Validation error message when the title of the saved snippet is empty.
692+
///
693+
/// In en, this message translates to:
694+
/// **'Title cannot be empty.'**
695+
String get savedSnippetTitleValidationErrorEmpty;
696+
697+
/// Validation error message when the title of the saved snippet is too long.
698+
///
699+
/// In en, this message translates to:
700+
/// **'Title length shouldn\'t be greater than 60 characters.'**
701+
String get savedSnippetTitleValidationErrorTooLong;
702+
703+
/// Validation error message when the content of the saved snippet is empty.
704+
///
705+
/// In en, this message translates to:
706+
/// **'Content cannot be empty.'**
707+
String get savedSnippetContentValidationErrorEmpty;
708+
709+
/// Validation error message when the content of the saved snippet is too long.
710+
///
711+
/// In en, this message translates to:
712+
/// **'Content length shouldn\'t be greater than 10000 characters.'**
713+
String get savedSnippetContentValidationErrorTooLong;
714+
643715
/// Hint text for content input when sending a message.
644716
///
645717
/// In en, this message translates to:

‎lib/generated/l10n/zulip_localizations_ar.dart‎

Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -323,6 +323,46 @@ class ZulipLocalizationsAr extends ZulipLocalizations {
323323
@override
324324
String get composeBoxAttachFromCameraTooltip => 'Take a photo';
325325

326+
@override
327+
String get composeBoxShowSavedSnippetsTooltip => 'Show saved snippets';
328+
329+
@override
330+
String get noSavedSnippets => 'No saved snippets';
331+
332+
@override
333+
String get savedSnippetsTitle => 'Saved snippets';
334+
335+
@override
336+
String get newSavedSnippetButton => 'New';
337+
338+
@override
339+
String get newSavedSnippetTitle => 'New snippet';
340+
341+
@override
342+
String get newSavedSnippetTitleHint => 'Title';
343+
344+
@override
345+
String get newSavedSnippetContentHint => 'Content';
346+
347+
@override
348+
String get errorFailedToCreateSavedSnippetTitle =>
349+
'Failed to create saved snippet';
350+
351+
@override
352+
String get savedSnippetTitleValidationErrorEmpty => 'Title cannot be empty.';
353+
354+
@override
355+
String get savedSnippetTitleValidationErrorTooLong =>
356+
'Title length shouldn\'t be greater than 60 characters.';
357+
358+
@override
359+
String get savedSnippetContentValidationErrorEmpty =>
360+
'Content cannot be empty.';
361+
362+
@override
363+
String get savedSnippetContentValidationErrorTooLong =>
364+
'Content length shouldn\'t be greater than 10000 characters.';
365+
326366
@override
327367
String get composeBoxGenericContentHint => 'Type a message';
328368

‎lib/generated/l10n/zulip_localizations_en.dart‎

Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -323,6 +323,46 @@ class ZulipLocalizationsEn extends ZulipLocalizations {
323323
@override
324324
String get composeBoxAttachFromCameraTooltip => 'Take a photo';
325325

326+
@override
327+
String get composeBoxShowSavedSnippetsTooltip => 'Show saved snippets';
328+
329+
@override
330+
String get noSavedSnippets => 'No saved snippets';
331+
332+
@override
333+
String get savedSnippetsTitle => 'Saved snippets';
334+
335+
@override
336+
String get newSavedSnippetButton => 'New';
337+
338+
@override
339+
String get newSavedSnippetTitle => 'New snippet';
340+
341+
@override
342+
String get newSavedSnippetTitleHint => 'Title';
343+
344+
@override
345+
String get newSavedSnippetContentHint => 'Content';
346+
347+
@override
348+
String get errorFailedToCreateSavedSnippetTitle =>
349+
'Failed to create saved snippet';
350+
351+
@override
352+
String get savedSnippetTitleValidationErrorEmpty => 'Title cannot be empty.';
353+
354+
@override
355+
String get savedSnippetTitleValidationErrorTooLong =>
356+
'Title length shouldn\'t be greater than 60 characters.';
357+
358+
@override
359+
String get savedSnippetContentValidationErrorEmpty =>
360+
'Content cannot be empty.';
361+
362+
@override
363+
String get savedSnippetContentValidationErrorTooLong =>
364+
'Content length shouldn\'t be greater than 10000 characters.';
365+
326366
@override
327367
String get composeBoxGenericContentHint => 'Type a message';
328368

‎lib/generated/l10n/zulip_localizations_ja.dart‎

Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -323,6 +323,46 @@ class ZulipLocalizationsJa extends ZulipLocalizations {
323323
@override
324324
String get composeBoxAttachFromCameraTooltip => 'Take a photo';
325325

326+
@override
327+
String get composeBoxShowSavedSnippetsTooltip => 'Show saved snippets';
328+
329+
@override
330+
String get noSavedSnippets => 'No saved snippets';
331+
332+
@override
333+
String get savedSnippetsTitle => 'Saved snippets';
334+
335+
@override
336+
String get newSavedSnippetButton => 'New';
337+
338+
@override
339+
String get newSavedSnippetTitle => 'New snippet';
340+
341+
@override
342+
String get newSavedSnippetTitleHint => 'Title';
343+
344+
@override
345+
String get newSavedSnippetContentHint => 'Content';
346+
347+
@override
348+
String get errorFailedToCreateSavedSnippetTitle =>
349+
'Failed to create saved snippet';
350+
351+
@override
352+
String get savedSnippetTitleValidationErrorEmpty => 'Title cannot be empty.';
353+
354+
@override
355+
String get savedSnippetTitleValidationErrorTooLong =>
356+
'Title length shouldn\'t be greater than 60 characters.';
357+
358+
@override
359+
String get savedSnippetContentValidationErrorEmpty =>
360+
'Content cannot be empty.';
361+
362+
@override
363+
String get savedSnippetContentValidationErrorTooLong =>
364+
'Content length shouldn\'t be greater than 10000 characters.';
365+
326366
@override
327367
String get composeBoxGenericContentHint => 'Type a message';
328368

‎lib/generated/l10n/zulip_localizations_nb.dart‎

Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -323,6 +323,46 @@ class ZulipLocalizationsNb extends ZulipLocalizations {
323323
@override
324324
String get composeBoxAttachFromCameraTooltip => 'Take a photo';
325325

326+
@override
327+
String get composeBoxShowSavedSnippetsTooltip => 'Show saved snippets';
328+
329+
@override
330+
String get noSavedSnippets => 'No saved snippets';
331+
332+
@override
333+
String get savedSnippetsTitle => 'Saved snippets';
334+
335+
@override
336+
String get newSavedSnippetButton => 'New';
337+
338+
@override
339+
String get newSavedSnippetTitle => 'New snippet';
340+
341+
@override
342+
String get newSavedSnippetTitleHint => 'Title';
343+
344+
@override
345+
String get newSavedSnippetContentHint => 'Content';
346+
347+
@override
348+
String get errorFailedToCreateSavedSnippetTitle =>
349+
'Failed to create saved snippet';
350+
351+
@override
352+
String get savedSnippetTitleValidationErrorEmpty => 'Title cannot be empty.';
353+
354+
@override
355+
String get savedSnippetTitleValidationErrorTooLong =>
356+
'Title length shouldn\'t be greater than 60 characters.';
357+
358+
@override
359+
String get savedSnippetContentValidationErrorEmpty =>
360+
'Content cannot be empty.';
361+
362+
@override
363+
String get savedSnippetContentValidationErrorTooLong =>
364+
'Content length shouldn\'t be greater than 10000 characters.';
365+
326366
@override
327367
String get composeBoxGenericContentHint => 'Type a message';
328368

‎lib/generated/l10n/zulip_localizations_pl.dart‎

Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -330,6 +330,46 @@ class ZulipLocalizationsPl extends ZulipLocalizations {
330330
@override
331331
String get composeBoxAttachFromCameraTooltip => 'Zrób zdjęcie';
332332

333+
@override
334+
String get composeBoxShowSavedSnippetsTooltip => 'Show saved snippets';
335+
336+
@override
337+
String get noSavedSnippets => 'No saved snippets';
338+
339+
@override
340+
String get savedSnippetsTitle => 'Saved snippets';
341+
342+
@override
343+
String get newSavedSnippetButton => 'New';
344+
345+
@override
346+
String get newSavedSnippetTitle => 'New snippet';
347+
348+
@override
349+
String get newSavedSnippetTitleHint => 'Title';
350+
351+
@override
352+
String get newSavedSnippetContentHint => 'Content';
353+
354+
@override
355+
String get errorFailedToCreateSavedSnippetTitle =>
356+
'Failed to create saved snippet';
357+
358+
@override
359+
String get savedSnippetTitleValidationErrorEmpty => 'Title cannot be empty.';
360+
361+
@override
362+
String get savedSnippetTitleValidationErrorTooLong =>
363+
'Title length shouldn\'t be greater than 60 characters.';
364+
365+
@override
366+
String get savedSnippetContentValidationErrorEmpty =>
367+
'Content cannot be empty.';
368+
369+
@override
370+
String get savedSnippetContentValidationErrorTooLong =>
371+
'Content length shouldn\'t be greater than 10000 characters.';
372+
333373
@override
334374
String get composeBoxGenericContentHint => 'Wpisz wiadomość';
335375

0 commit comments

Comments
 (0)