Skip to content

Commit 4480e3b

Browse files
gnpricegnprice
committed
test [nfc]: Use store.addMessage shortcut everywhere
1 parent ca0abe5 commit 4480e3b

File tree

3 files changed

+28
-28
lines changed

3 files changed

+28
-28
lines changed

‎test/model/message_list_test.dart‎

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1450,28 +1450,28 @@ void main() {
14501450
.deepEquals(expected..insertAll(0, [101, 103, 105]));
14511451

14521452
// … and on MessageEvent.
1453-
await store.handleEvent(eg.messageEvent(
1454-
eg.streamMessage(id: 301, stream: stream1, topic: 'A')));
1453+
await store.addMessage(
1454+
eg.streamMessage(id: 301, stream: stream1, topic: 'A'));
14551455
checkNotifiedOnce();
14561456
check(model.messages.map((m) => m.id)).deepEquals(expected..add(301));
14571457

1458-
await store.handleEvent(eg.messageEvent(
1459-
eg.streamMessage(id: 302, stream: stream1, topic: 'B')));
1458+
await store.addMessage(
1459+
eg.streamMessage(id: 302, stream: stream1, topic: 'B'));
14601460
checkNotNotified();
14611461
check(model.messages.map((m) => m.id)).deepEquals(expected);
14621462

1463-
await store.handleEvent(eg.messageEvent(
1464-
eg.streamMessage(id: 303, stream: stream2, topic: 'C')));
1463+
await store.addMessage(
1464+
eg.streamMessage(id: 303, stream: stream2, topic: 'C'));
14651465
checkNotifiedOnce();
14661466
check(model.messages.map((m) => m.id)).deepEquals(expected..add(303));
14671467

1468-
await store.handleEvent(eg.messageEvent(
1469-
eg.streamMessage(id: 304, stream: stream2, topic: 'D')));
1468+
await store.addMessage(
1469+
eg.streamMessage(id: 304, stream: stream2, topic: 'D'));
14701470
checkNotNotified();
14711471
check(model.messages.map((m) => m.id)).deepEquals(expected);
14721472

1473-
await store.handleEvent(eg.messageEvent(
1474-
eg.dmMessage(id: 305, from: eg.otherUser, to: [eg.selfUser])));
1473+
await store.addMessage(
1474+
eg.dmMessage(id: 305, from: eg.otherUser, to: [eg.selfUser]));
14751475
checkNotifiedOnce();
14761476
check(model.messages.map((m) => m.id)).deepEquals(expected..add(305));
14771477
});
@@ -1507,18 +1507,18 @@ void main() {
15071507
.deepEquals(expected..insertAll(0, [101, 102]));
15081508

15091509
// … and on MessageEvent.
1510-
await store.handleEvent(eg.messageEvent(
1511-
eg.streamMessage(id: 301, stream: stream, topic: 'A')));
1510+
await store.addMessage(
1511+
eg.streamMessage(id: 301, stream: stream, topic: 'A'));
15121512
checkNotifiedOnce();
15131513
check(model.messages.map((m) => m.id)).deepEquals(expected..add(301));
15141514

1515-
await store.handleEvent(eg.messageEvent(
1516-
eg.streamMessage(id: 302, stream: stream, topic: 'B')));
1515+
await store.addMessage(
1516+
eg.streamMessage(id: 302, stream: stream, topic: 'B'));
15171517
checkNotifiedOnce();
15181518
check(model.messages.map((m) => m.id)).deepEquals(expected..add(302));
15191519

1520-
await store.handleEvent(eg.messageEvent(
1521-
eg.streamMessage(id: 303, stream: stream, topic: 'C')));
1520+
await store.addMessage(
1521+
eg.streamMessage(id: 303, stream: stream, topic: 'C'));
15221522
checkNotNotified();
15231523
check(model.messages.map((m) => m.id)).deepEquals(expected);
15241524
});
@@ -1549,8 +1549,8 @@ void main() {
15491549
.deepEquals(expected..insertAll(0, [101]));
15501550

15511551
// … and on MessageEvent.
1552-
await store.handleEvent(eg.messageEvent(
1553-
eg.streamMessage(id: 301, stream: stream, topic: 'A')));
1552+
await store.addMessage(
1553+
eg.streamMessage(id: 301, stream: stream, topic: 'A'));
15541554
checkNotifiedOnce();
15551555
check(model.messages.map((m) => m.id)).deepEquals(expected..add(301));
15561556
});
@@ -1589,7 +1589,7 @@ void main() {
15891589
// … and on MessageEvent.
15901590
final messages = getMessages(301);
15911591
for (var i = 0; i < 3; i += 1) {
1592-
await store.handleEvent(eg.messageEvent(messages[i]));
1592+
await store.addMessage(messages[i]);
15931593
checkNotifiedOnce();
15941594
check(model.messages.map((m) => m.id)).deepEquals(expected..add(301 + i));
15951595
}
@@ -1627,7 +1627,7 @@ void main() {
16271627
// … and on MessageEvent.
16281628
final messages = getMessages(301);
16291629
for (var i = 0; i < 2; i += 1) {
1630-
await store.handleEvent(eg.messageEvent(messages[i]));
1630+
await store.addMessage(messages[i]);
16311631
checkNotifiedOnce();
16321632
check(model.messages.map((m) => m.id)).deepEquals(expected..add(301 + i));
16331633
}
@@ -1718,11 +1718,11 @@ void main() {
17181718
checkNotified(count: 2);
17191719

17201720
// Then test MessageEvent, where a new header is needed…
1721-
await store.handleEvent(eg.messageEvent(streamMessage(13)));
1721+
await store.addMessage(streamMessage(13));
17221722
checkNotifiedOnce();
17231723

17241724
// … and where it's not.
1725-
await store.handleEvent(eg.messageEvent(streamMessage(14)));
1725+
await store.addMessage(streamMessage(14));
17261726
checkNotifiedOnce();
17271727

17281728
// Then test UpdateMessageEvent edits, where a header is and remains needed…

‎test/model/message_test.dart‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ void main() {
129129
check(store.messages).isEmpty();
130130

131131
final newMessage = eg.streamMessage();
132-
await store.handleEvent(eg.messageEvent(newMessage));
132+
await store.addMessage(newMessage);
133133
check(store.messages).deepEquals({
134134
newMessage.id: newMessage,
135135
});
@@ -148,7 +148,7 @@ void main() {
148148
});
149149

150150
final newMessage = eg.streamMessage();
151-
await store.handleEvent(eg.messageEvent(newMessage));
151+
await store.addMessage(newMessage);
152152
check(store.messages).deepEquals({
153153
for (final m in messages) m.id: m,
154154
newMessage.id: newMessage,
@@ -162,7 +162,7 @@ void main() {
162162
check(store.messages).deepEquals({1: message});
163163

164164
final newMessage = eg.streamMessage(id: 1, content: '<p>bar</p>');
165-
await store.handleEvent(eg.messageEvent(newMessage));
165+
await store.addMessage(newMessage);
166166
check(store.messages).deepEquals({1: newMessage});
167167
});
168168
});
@@ -859,7 +859,7 @@ void main() {
859859
]);
860860

861861
await prepare();
862-
await store.handleEvent(eg.messageEvent(message));
862+
await store.addMessage(message);
863863
}
864864

865865
test('smoke', () async {
@@ -930,7 +930,7 @@ void main() {
930930
),
931931
]);
932932
await prepare();
933-
await store.handleEvent(eg.messageEvent(message));
933+
await store.addMessage(message);
934934
check(store.messages[message.id]).isNotNull().poll.isNull();
935935
});
936936
});

‎test/widgets/message_list_test.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1510,7 +1510,7 @@ void main() {
15101510

15111511
// introduce new message
15121512
final newMessage = eg.streamMessage(flags:[MessageFlag.read]);
1513-
await store.handleEvent(eg.messageEvent(newMessage));
1513+
await store.addMessage(newMessage);
15141514
await tester.pump(); // process handleEvent
15151515
check(find.byType(MessageItem).evaluate()).length.equals(2);
15161516
check(getAnimation(tester, message.id))

0 commit comments

Comments
 (0)