Improve error handling for invalid JSON in global_config.json
#1404
Labels
Comments
|
@timabbott I am unable to find global_config.json file can you please specify which global_config.json file you are referring to? |
sammamama
added a commit
to sammamama/zulip-desktop
that referenced
this issue
Feb 2, 2025
Fixes zulip#1404. I added a dialog box error function, that gets thrown whenever json format is found to be incorrect.
15 tasks
|
@timabbott I've created a Draft PR. Please let me know any further changes if required. |
sammamama
added a commit
to sammamama/zulip-desktop
that referenced
this issue
Feb 4, 2025
Fixes zulip#1404. I added a dialog box error function, that gets thrown whenever json format is found to be incorrect. fixed dialog import
sammamama
added a commit
to sammamama/zulip-desktop
that referenced
this issue
Feb 6, 2025
…rrect format Fixes zulip#1404. I added a dialog box error function, that gets thrown whenever json format is found to be incorrect.
|
@zulipbot claim |
|
Hello @Prince-Singh-05! Thanks for your interest in Zulip! You have attempted to claim an issue without the label "help wanted". You can only claim and submit pull requests for issues with the help wanted label. If this is your first time here, we recommend reading our guide for new contributors before getting started. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Users who have invalid JSON in their
global_config.jsonfile, which is kinda easy to do if you hand-edit JSON and are not good at remembering to skip commas, experience a blank screen when trying to open the application; the only visible errors are in the JS console for the app.We should introduce a more reasonable user-facing failure here.
The text was updated successfully, but these errors were encountered: