link_utils: exposing whitelisted protocols to user settings

This commit exposes the whitelisted protocol list to the user
settings.json file. This allows user to extend or modify the list of
linkifiers that are directly opened by the os instead of being opened
via the redirect html method.
link_utils: exposing whitelisted protocols to user settings

This commit exposes the whitelisted protocol list to the user
settings.json file. This allows user to extend or modify the list of
linkifiers that are directly opened by the os instead of being opened
via the redirect html method.

xo: Use eslint-import-resolver-typescript.

Signed-off-by: Anders Kaseorg <[email protected]>

xo: Prohibit main-only and renderer-only APIs in wrong processes.

Signed-off-by: Anders Kaseorg <[email protected]>

link_utils: exposing whitelisted protocols to user settings

This commit exposes the whitelisted protocol list to the user
settings.json file. This allows user to extend or modify the list of
linkifiers that are directly opened by the os instead of being opened
via the redirect html method.

Fix Merge Conflicts Main Branch

Fix Merge Conflicts Main Branch

link_utils: exposing whitelisted protocols to user settings

This commit exposes the whitelisted protocol list to the user
settings.json file. This allows user to extend or modify the list of
linkifiers that are directly opened by the os instead of being opened
via the redirect html method.

Fix Merge Conflicts Main Branch

Fix Merge Conflicts Main Branch

Author: jonassorgenfrei

app/common/config-schemata.ts

@@ -36,6 +36,7 @@ export const configSchemata = {
   useManualProxy: z.boolean(),
   useProxy: z.boolean(),
   useSystemProxy: z.boolean(),
+  whitelistedProtocols: z.string().array(),
 };
 
 export const enterpriseConfigSchemata = {

app/common/config-util.ts

@@ -7,9 +7,9 @@ import {DataError} from "node-json-db/dist/lib/Errors";
 import type {z} from "zod";
 import {app, dialog} from "zulip:remote";
 
-import {configSchemata} from "./config-schemata.js";
-import * as EnterpriseUtil from "./enterprise-util.js";
-import Logger from "./logger-util.js";
+import {configSchemata} from "./config-schemata.ts";
+import * as EnterpriseUtil from "./enterprise-util.ts";
+import Logger from "./logger-util.ts";
 
 export type Config = {
   [Key in keyof typeof configSchemata]: z.output<(typeof configSchemata)[Key]>;

app/common/dnd-util.ts

@@ -2,8 +2,8 @@ import process from "node:process";
 
 import type {z} from "zod";
 
-import type {dndSettingsSchemata} from "./config-schemata.js";
-import * as ConfigUtil from "./config-util.js";
+import type {dndSettingsSchemata} from "./config-schemata.ts";
+import * as ConfigUtil from "./config-util.ts";
 
 export type DndSettings = {
   [Key in keyof typeof dndSettingsSchemata]: z.output<

app/common/enterprise-util.ts

@@ -5,8 +5,8 @@ import process from "node:process";
 import {z} from "zod";
 import {dialog} from "zulip:remote";
 
-import {enterpriseConfigSchemata} from "./config-schemata.js";
-import Logger from "./logger-util.js";
+import {enterpriseConfigSchemata} from "./config-schemata.ts";
+import Logger from "./logger-util.ts";
 
 type EnterpriseConfig = {
   [Key in keyof typeof enterpriseConfigSchemata]: z.output<

app/common/link-util.ts

@@ -3,10 +3,20 @@ import fs from "node:fs";
 import os from "node:os";
 import path from "node:path";
 
-import {html} from "./html.js";
+import * as ConfigUtil from "./config-util.ts";
+import {html} from "./html.ts";
+
+/* Fetches the current protocolLaunchers from settings.json */
+const whitelistedProtocols = ConfigUtil.getConfigItem("whitelistedProtocols", [
+  "http:",
+  "https:",
+  "mailto:",
+  "tel:",
+  "sip:",
+]);
 
 export async function openBrowser(url: URL): Promise<void> {
-  if (["http:", "https:", "mailto:"].includes(url.protocol)) {
+  if (whitelistedProtocols.includes(url.protocol)) {
     await shell.openExternal(url.href);
   } else {
     // For security, indirect links to non-whitelisted protocols

app/common/logger-util.ts

@@ -5,7 +5,7 @@ import process from "node:process";
 
 import {app} from "zulip:remote";
 
-import {initSetUp} from "./default-util.js";
+import {initSetUp} from "./default-util.ts";
 
 type LoggerOptions = {
   file?: string;

app/common/translation-util.ts

@@ -2,8 +2,8 @@ import path from "node:path";
 
 import i18n from "i18n";
 
-import * as ConfigUtil from "./config-util.js";
-import {publicPath} from "./paths.js";
+import * as ConfigUtil from "./config-util.ts";
+import {publicPath} from "./paths.ts";
 
 i18n.configure({
   directory: path.join(publicPath, "translations/"),

app/common/typed-ipc.ts

@@ -1,5 +1,5 @@
-import type {DndSettings} from "./dnd-util.js";
-import type {MenuProperties, ServerConfig} from "./types.js";
+import type {DndSettings} from "./dnd-util.ts";
+import type {MenuProperties, ServerConfig} from "./types.ts";
 
 export type MainMessage = {
   "clear-app-settings": () => void;

app/main/autoupdater.ts

@@ -9,10 +9,10 @@ import {
   autoUpdater,
 } from "electron-updater";
 
-import * as ConfigUtil from "../common/config-util.js";
-import * as t from "../common/translation-util.js";
+import * as ConfigUtil from "../common/config-util.ts";
+import * as t from "../common/translation-util.ts";
 
-import {linuxUpdateNotification} from "./linuxupdater.js"; // Required only in case of linux
+import {linuxUpdateNotification} from "./linuxupdater.ts"; // Required only in case of linux
 
 let quitting = false;
 

app/main/badge-settings.ts

@@ -2,9 +2,9 @@ import {nativeImage} from "electron/common";
 import {type BrowserWindow, app} from "electron/main";
 import process from "node:process";
 
-import * as ConfigUtil from "../common/config-util.js";
+import * as ConfigUtil from "../common/config-util.ts";
 
-import {send} from "./typed-ipc-main.js";
+import {send} from "./typed-ipc-main.ts";
 
 function showBadgeCount(messageCount: number, mainWindow: BrowserWindow): void {
   if (process.platform === "win32") {