-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No status to indicate aborted transaction. #63
Comments
AFAIR You're probably looking for |
@mgedmin, looking at the |
|
@mmerickel, correct. I ran into a problem where I had a transaction object Which also revealed the second problem that So this issue really contains two aspects:
|
This issue is maybe related to #48. |
Leaving #48 aside :), I'm fine with this, even though I never wanted. It's a logical thing to do to model/express the life-cycle of transactions. I'd support a (presumably simple :-]) PR. |
@jimfulton, here you go: pull request #64 😉 |
This works:
and this does’t:
Looking at the current status code definition:
transaction/transaction/_transaction.py
Lines 53 to 64 in 501a293
then an
"Aborted"
status is missing, but I think would be quite sensible and useful to have.And having said that, it would also make sense to either export the
Status
publicly or addis_active()
(etc.) helper functions to the ITransaction interface so that the status of a transaction can be checked conveniently.The text was updated successfully, but these errors were encountered: