Skip to content

Allow to use the package with Python 3.12. #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 10, 2023
Merged

Allow to use the package with Python 3.12. #248

merged 6 commits into from
Mar 10, 2023

Conversation

icemac
Copy link
Member

@icemac icemac commented Mar 7, 2023

See #246.

@icemac icemac requested a review from dataflake March 7, 2023 07:04
@icemac icemac self-assigned this Mar 7, 2023
@icemac
Copy link
Member Author

icemac commented Mar 7, 2023

I have no idea why Windows 3.12 fails: https://github.com/zopefoundation/RestrictedPython/actions/runs/4351559170/jobs/7603343628

@icemac
Copy link
Member Author

icemac commented Mar 7, 2023

I created pypa/pip#11844 for the Windows 3.12 issue.

mauritsvanrees
mauritsvanrees reviewed Mar 7, 2023
View reviewed changes
@icemac
Copy link
Member Author

icemac commented Mar 10, 2023

I just removed the pip list call which is not absolutely necessary. Now the tests are green.

Thank you for reviewing this PR. 😃

@icemac icemac merged commit 1a8011b into master Mar 10, 2023
@icemac icemac deleted the py312 branch March 10, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauritsvanrees mauritsvanrees mauritsvanrees left review comments

@dataflake dataflake dataflake approved these changes

Assignees

@icemac icemac

Labels
enhancement
Projects
Alpine City Sprint 2023 and beyond
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@icemac @mauritsvanrees @dataflake