Harmonize `name server` and `nameserver`

[jsoref]

https://github.com/search?q=repo%3Azonemaster%2Fzonemaster-engine+%2F+name+%3Fserver+%5B%5E%3D%5D%2F+NOT+language%3A%22Gettext+Catalog%22+language%3APerl+&type=code

There are probably times where it makes sense to use name server instead of nameserver, however,...

https://github.com/search?q=repo%3Azonemaster%2Fzonemaster-engine+%2F%5B%22+%5Dname+%3Fserver+%5B%7B%5D%2F+NOT+language%3A%22Gettext+Catalog%22+language%3APerl+&type=code

zonemaster-engine/lib/Zonemaster/Engine/Translator.pm

Line 84 in 17688f7

"Name server {ns} not adding fake delegation for domain {domain} to itself.", @_;

zonemaster-engine/lib/Zonemaster/Engine/Translator.pm

Line 88 in 17688f7

"The fake delegation of domain {domain} includes an in-zone name server {nsname} "

zonemaster-engine/lib/Zonemaster/Engine/Test/Delegation.pm

Line 278 in 17688f7

"Nameserver {ns} did not respond.", @_;

zonemaster-engine/lib/Zonemaster/Engine/Test/Nameserver.pm

Line 353 in 17688f7

'AXFR not available on nameserver {ns}.', @_;

[matsduf]

@jsoref, thank you for your comment. We are aware of the inconsistency in the messages. We will try to get consistent terms. RFC 9499 uses "name server" consistently, so there is good support for that.

[jsoref]

I'm happy to create a PR for this if you're open to it.

[tgreenx]

I'm happy to create a PR for this if you're open to it.

Yes of course, please do, much appreciated !

[tgreenx]

Hi @jsoref, what is the status of this issue? I see you opened a draft PR on your fork, is it complete?

[jsoref]

@tgreenx: it looks like CI failed... I don't remember why, but it's certainly possible I couldn't figure out how to make it happy. I'll rebase and see if it has something to say.

It also looks like I totally missed wrt where I targeted the PR. That isn't how I'd usually target PRs, so it feels like I wasn't trying to do that...

[tgreenx]

No worries, just checking in, you can take your time. We just had a new release so the next one won't happen before a little while. Thanks again.