-
Notifications
You must be signed in to change notification settings - Fork 22
Description
There are combinations of command-line options to zonemaster-cli that do not make sense together, and should be rejected as usage errors.
Some examples:
-
A command line such as
zonemaster-cli --help --list-tests --version --dump-profiledoesn’t make sense at all, because all of these options select different modes. Any two of these options combined together should be rejected as an invalid command line. -
In the synopsis, one line says
zonemaster-cli [OPTIONS] --dump-profile. Because--dump-profileselects a different mode than the default one, there is just a small subset ofOPTIONSthat do make sense with--dump-profile. Which ones are acceptable, besides--profile=FILE? Combinations, such as the somewhat sillyzonemaster-cli --dump-profile --no-json(because the--no-jsonapplies to the output of zone testing and not profile dumps), should be rejected. -
The error messages displayed on erroneous values for
--leveland--stop-levelare inconsistent:
$ zonemaster-cli --stop-level=INVALID
Failed to recognize stop level 'INVALID'.
$ zonemaster-cli --level=INVALID
--level must be one of CRITICAL, ERROR, WARNING, NOTICE, INFO, DEBUG, DEBUG2 or DEBUG3.