Clean-up in database configuration

[matsduf]

As far as I can see Zonemaster::Backend::DB::sub store_results() is not used anywhere besides in t/lifecycle.tand could be removed.

https://github.com/zonemaster/zonemaster-backend/blob/develop/lib/Zonemaster/Backend/DB.pm#L431-L449

Furthermore, the database definitions of table "test_results" include a field "results" which is not used anymore, as far as I can see.

[marc-vanderwal]

Zonemaster::Backend::DB::store_results seems to be used only in t/lifecycle.t. This unit test file isn’t trivial and needs careful scrutiny before deleting anything.

Before dropping the results column from the test_results table, some queries need to be rewritten in Zonemaster::Backend::DB. One offender is in the store_results function (and might just be dead code) and two more are in select_unfinished_tests.

[anandb-ripencc]

This issue was meant to be resolved for 2024.1. Has it been resolved, or did it not make it to the 2024.1 version?

[tgreenx]

This issue was meant to be resolved for 2024.1. Has it been resolved, or did it not make it to the 2024.1 version?

@anandb-ripencc Unfortunately it did not get fixed yet. Is this a priority on your end?

[anandb-ripencc]

It's not a priority, because the obsolete "results" column doesn't do any harm. I was just wondering about the status, because this was marked for fixing in 2024.1.

[tgreenx]

It's not a priority, because the obsolete "results" column doesn't do any harm. I was just wondering about the status, because this was marked for fixing in 2024.1.

I see. Honestly our current way of assigning milestones on issues is mostly untrustworthy. Usually most issues are assigned the milestone of the next-to-come release, unless we have good reason to do otherwise. A better indicator is to look at issues marked as high priority ("P-High") and/or that come directly from users ("T-Question").