From 101f5c97c9a50f8d82c56197564615524f1361a9 Mon Sep 17 00:00:00 2001 From: D See Ker Date: Thu, 9 Apr 2020 07:45:50 +0000 Subject: [PATCH 1/4] TypeError Cannot read 'statusCode' of undefined TypeError: Cannot read property 'statusCode' of undefined at Request._callback (/app/node_modules/zcrmsdk/lib/js/util.js:129:21) at self.callback (/app/node_modules/request/request.js:185:22) at Request.emit (events.js:198:13) at Request.EventEmitter.emit (domain.js:448:20) at Request.onRequestError (/app/node_modules/request/request.js:877:8) at ClientRequest.emit (events.js:198:13) at ClientRequest.EventEmitter.emit (domain.js:448:20) at TLSSocket.socketOnEnd (_http_client.js:435:9) at TLSSocket.emit (events.js:203:15) at TLSSocket.EventEmitter.emit (domain.js:448:20) --- lib/js/util.js | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/lib/js/util.js b/lib/js/util.js index 70a55f3..33f9004 100644 --- a/lib/js/util.js +++ b/lib/js/util.js @@ -112,6 +112,13 @@ function makeapicall(request){ if(error){ resolve(error); } + else if(!response){ + var respObj = { + "message" : "failed response", //No I18N + "status_code" : "204" //No I18N + } + resolve(JSON.stringify(respObj)); + } else if(response.statusCode == 204){ var respObj = { @@ -239,4 +246,4 @@ module.exports = { constructRequestDetails : constructRequestDetails, promiseResponse : promiseResponse, -} \ No newline at end of file +} From 06771f45b64b43a7d51eaae8cce282fd10397ced Mon Sep 17 00:00:00 2001 From: D See Ker Date: Thu, 9 Apr 2020 07:47:29 +0000 Subject: [PATCH 2/4] bump version --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 426491a..5e41080 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "zcrmsdk", - "version": "0.0.20", + "version": "0.0.21", "description": "Node SDK for Zoho CRM", "main": "lib/js/ZCRMRestClient", "dependencies": { From 8426c1d06bd0b7a9ce2d8a26478a6d10587f30e5 Mon Sep 17 00:00:00 2001 From: D See Ker Date: Fri, 5 Jun 2020 20:35:21 +0000 Subject: [PATCH 3/4] emit log in async throw new error does not show any errors in async chain --- lib/js/ZCRMRestClient.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/js/ZCRMRestClient.js b/lib/js/ZCRMRestClient.js index cefbe21..7989dd2 100644 --- a/lib/js/ZCRMRestClient.js +++ b/lib/js/ZCRMRestClient.js @@ -138,7 +138,8 @@ var default_user_identifier = "zcrm_default_user"; ); } else{ - + console.log("Problem occured while generating access token from refresh token. Response : "+JSON.stringify(response)) + reject(resultObj) throw new Error("Problem occured while generating access token and refresh token from grant token.Response : "+JSON.stringify(response)); } }) @@ -335,4 +336,4 @@ ZCRMRestClient.parseAndConstructObject = function(response){ ZCRMRestClient.API = require('./crmapi'); - module.exports = ZCRMRestClient; \ No newline at end of file + module.exports = ZCRMRestClient; From 5e58370364c64d8dcf30341c949cebcbddc15524 Mon Sep 17 00:00:00 2001 From: D See Ker Date: Fri, 5 Jun 2020 20:35:44 +0000 Subject: [PATCH 4/4] Update package.json --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 5e41080..0a1b728 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "zcrmsdk", - "version": "0.0.21", + "version": "0.0.22", "description": "Node SDK for Zoho CRM", "main": "lib/js/ZCRMRestClient", "dependencies": {