Skip to content

Commit e17ed7b

Browse files
🧹 [Code Health] Use proper logging instead of console.warn for fallback saves
Replaces console.warn with this.viewerProvider.outputChannel in DatabaseDocument for direct write fallback scenarios.
1 parent 776ed72 commit e17ed7b

2 files changed

Lines changed: 16 additions & 18 deletions

File tree

‎src/databaseModel.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -377,7 +377,7 @@ export class DatabaseDocument extends Disposable implements vsc.CustomDocument {
377377
return;
378378
} catch (e) {
379379
// Fallback if direct write fails
380-
console.warn('Direct write failed, falling back to buffer transfer', e);
380+
this.viewerProvider.outputChannel?.appendLine(`[Fallback] Direct write failed, falling back to buffer transfer: ${e instanceof Error ? e.message : String(e)}`);
381381
}
382382
}
383383

@@ -425,7 +425,7 @@ export class DatabaseDocument extends Disposable implements vsc.CustomDocument {
425425
await this.databaseOperations.writeToFile(targetUri.fsPath);
426426
return;
427427
} catch (e) {
428-
console.warn('Direct write failed, falling back to buffer transfer', e);
428+
this.viewerProvider.outputChannel?.appendLine(`[Fallback] Direct write failed, falling back to buffer transfer: ${e instanceof Error ? e.message : String(e)}`);
429429
}
430430
}
431431

‎tests/unit/databaseModel.test.ts‎

Lines changed: 14 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -365,15 +365,14 @@ describe('DatabaseDocument save/saveAs fallback', () => {
365365
configurable: true
366366
});
367367

368-
const originalConsoleWarn = console.warn;
369368
let consoleWarnCalled = false;
370-
console.warn = (msg: string, err: any) => {
371-
if (msg && msg.includes('Direct write failed')) {
372-
consoleWarnCalled = true;
373-
} else {
374-
originalConsoleWarn(msg, err);
369+
doc.viewerProvider.outputChannel = {
370+
appendLine: (msg: string) => {
371+
if (msg && msg.includes('Direct write failed')) {
372+
consoleWarnCalled = true;
373+
}
375374
}
376-
};
375+
} as any;
377376

378377
try {
379378
await doc.saveAs(targetUri, undefined);
@@ -388,7 +387,7 @@ describe('DatabaseDocument save/saveAs fallback', () => {
388387
writable: true,
389388
configurable: true
390389
});
391-
console.warn = originalConsoleWarn;
390+
392391
}
393392
});
394393

@@ -424,15 +423,14 @@ describe('DatabaseDocument save/saveAs fallback', () => {
424423
configurable: true
425424
});
426425

427-
const originalConsoleWarn = console.warn;
428426
let consoleWarnCalled = false;
429-
console.warn = (msg: string, err: any) => {
430-
if (msg && msg.includes('Direct write failed')) {
431-
consoleWarnCalled = true;
432-
} else {
433-
originalConsoleWarn(msg, err);
427+
doc.viewerProvider.outputChannel = {
428+
appendLine: (msg: string) => {
429+
if (msg && msg.includes('Direct write failed')) {
430+
consoleWarnCalled = true;
431+
}
434432
}
435-
};
433+
} as any;
436434

437435
try {
438436
await doc.save();
@@ -446,7 +444,7 @@ describe('DatabaseDocument save/saveAs fallback', () => {
446444
writable: true,
447445
configurable: true
448446
});
449-
console.warn = originalConsoleWarn;
447+
450448
}
451449
});
452450

0 commit comments

Comments
 (0)