Skip to content

Commit 8bc1327

Browse files
zknprclaude
andcommitted
fix: improve filter UX with contextual empty messages and aria-label
Show "No matching tables/views/indexes" when filter yields no results instead of "No tables" which is misleading. Add aria-label for screen reader accessibility. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 4d1b839 commit 8bc1327

4 files changed

Lines changed: 8 additions & 8 deletions

File tree

core/ui/modules/sidebar.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -194,8 +194,8 @@ export function renderSidebar() {
194194
list.appendChild(fragment);
195195
};
196196

197-
renderList('tablesList', filteredTables, 'table', 'codicon-table', 'No tables');
198-
renderList('viewsList', filteredViews, 'view', 'codicon-eye', 'No views');
197+
renderList('tablesList', filteredTables, 'table', 'codicon-table', filter ? 'No matching tables' : 'No tables');
198+
renderList('viewsList', filteredViews, 'view', 'codicon-eye', filter ? 'No matching views' : 'No views');
199199

200200
const indexesList = document.getElementById('indexesList');
201201
if (indexesList) {
@@ -204,7 +204,7 @@ export function renderSidebar() {
204204
const li = document.createElement('li');
205205
li.className = 'list-item';
206206
li.style.opacity = '0.5';
207-
li.textContent = 'No indexes';
207+
li.textContent = filter ? 'No matching indexes' : 'No indexes';
208208
indexesList.appendChild(li);
209209
} else {
210210
const fragment = document.createDocumentFragment();

core/ui/viewer.html

Lines changed: 2 additions & 2 deletions
Large diffs are not rendered by default.

core/ui/viewer.template.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
</div>
2424

2525
<div class="sidebar-filter-container">
26-
<input type="text" class="sidebar-filter-input" id="sidebarFilterInput" placeholder="Filter...">
26+
<input type="text" class="sidebar-filter-input" id="sidebarFilterInput" placeholder="Filter..." aria-label="Filter tables, views, and indexes">
2727
</div>
2828

2929
<div class="sidebar-scroll-area">

website/public/sqlite-viewer/viewer.html

Lines changed: 2 additions & 2 deletions
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)