unwrap error unions, optionals, and pointers in goto type definition (#2321)

Author: xdBronch

src/features/goto.zig

@@ -38,7 +38,14 @@ fn gotoDefinitionSymbol(
         .definition => try decl_handle.definitionToken(analyser, true),
         .type_definition => blk: {
             if (try decl_handle.resolveType(analyser)) |ty| {
-                if (try ty.typeDefinitionToken()) |token_handle| break :blk token_handle;
+                var resolved_ty = ty;
+                while (true) {
+                    resolved_ty =
+                        try analyser.resolveUnwrapErrorUnionType(resolved_ty, .payload) orelse
+                        try analyser.resolveDerefType(resolved_ty) orelse
+                        try analyser.resolveOptionalUnwrap(resolved_ty) orelse break;
+                }
+                if (try resolved_ty.typeDefinitionToken()) |token_handle| break :blk token_handle;
             }
             const type_declaration = try decl_handle.typeDeclarationNode() orelse return null;
 

tests/lsp_features/definition.zig

@@ -260,6 +260,25 @@ test "non labeled break" {
     );
 }
 
+test "type definition unwraps error unions, optionals, pointers" {
+    try testDefinition(
+        \\const S = <tdef>struct</tdef> {};
+        \\const <>foo: error{}!S = .{};
+    );
+    try testDefinition(
+        \\const S = <tdef>struct</tdef> {};
+        \\const <>foo: ?S = .{};
+    );
+    try testDefinition(
+        \\const S = <tdef>struct</tdef> {};
+        \\const <>foo: *const S = &.{};
+    );
+    try testDefinition(
+        \\const S = <tdef>struct</tdef> {};
+        \\const <>foo: error{}!?*const S = &.{};
+    );
+}
+
 /// - use `<>` to indicate the cursor position
 /// - use `<decl>content</decl>` to set the expected range of the declaration
 /// - use `<def>content</def>` to set the expected range of the definition