Skip to content

Nits: managed-usage footer label + agent-core-v2 tool.test.ts lint/noise #16

Description

@zicochaos

Minor findings from the PR #12 review (pre-existing):

  1. apps/kimi-code/src/tui/utils/managed-usage-footer.ts compactRowLabel hardcodes 1w for any window with duration > 1 (assumes weeks). Should derive the unit from the window duration.
  2. packages/agent-core-v2/test/tool/tool.test.ts fake lacks getRequester, producing noisy stderr during the suite.
  3. Same file, lines 990 and 1042: 4 lint errors — typescript-eslint(no-base-to-string) / restrict-template-expressions on \...${execution.output}`in theexpected runnable executionthrow. These are the only errors makingpnpm run lintfail repo-wide (besides warnings). Stringify safely (e.g.JSON.stringify(execution.output)` or narrow the type).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions