Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine Authorise, AuthoriseEncrypted and Authorise3D structures #75

Open
zhutik opened this issue Feb 23, 2019 · 1 comment
Open

Combine Authorise, AuthoriseEncrypted and Authorise3D structures #75

zhutik opened this issue Feb 23, 2019 · 1 comment

Comments

@zhutik
Copy link
Owner

zhutik commented Feb 23, 2019

Currently, all Authorise, AuthoriseEncrypted and Authorise3D structures are used, but they are 95% identical.

AuthoriseEncrypted will be removed, "additionalData" field will be added to Authorise structure.
AuthoriseEncrypted method is Payment Gateway will be removed.
Authorise3D structure will be removed
Authorise3D method will be removed

@zhutik zhutik added this to the v0.5 milestone Feb 23, 2019
@zhutik zhutik changed the title Combine Authorise and AuthoriseEncrypted structures Combine Authorise, AuthoriseEncrypted and Authorise3D structures Feb 24, 2019
@jvalecillos
Copy link

Hello @zhutik, I'm currently working on adding new endpoints to the existing library and I just found out this issue about the duplicated structs and methods for payment authorization requests. There are even more gains about combining the methods, namely: supporting other payment methods.

My problem was: What about if other people is using these methods already?. So, my idea doing this in several steps:

  1. Combining the request struct in only one, and then the AuthoriseEncrypted, Authorise3D are just aliases of Authorise but adding a note about they are deprecated.
  2. In the same way the structs AuthoriseEncrypted and Authorise3D just embed a general Authorise.
  3. Finally, the methods and the duplicated structs are deleted altogether and increase a major version of the library.

Let me know your opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants