Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the interface between Token in models/tokens and Token in core/response. #15

Open
PopcornPaws opened this issue Jul 26, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@PopcornPaws
Copy link
Member

I think it would make the code easier to understand and maintain if these two types had slightly different names and there would be some kind of from_token and to_token methods that convert them into one another.

Furthermore, use Self instead of Token in core/response where applicable, to further differentiate between the two.

@PopcornPaws PopcornPaws added the enhancement New feature or request label Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant