js: Remove MeshoptSimplifier.useExperimentalFeatures

Both simplifyWithAttributes and simplifyPoints are stable and no longer
require experimental flag. Technically pruning is still considered
experimental but it would make more sense to just remove the boolean
setting as even if pruning changes in its behavior, that change will
only concern the implementation.

Author: zeux

demo/simplify.html

@@ -457,8 +457,6 @@
 
 			function simplify() {
 				MeshoptSimplifier.ready.then(function () {
-					MeshoptSimplifier.useExperimentalFeatures = true;
-
 					var threshold = Math.pow(10, -settings.errorThresholdLog10);
 
 					if (settings.autoLod) {

js/meshopt_simplifier.js

@@ -205,10 +205,6 @@ var MeshoptSimplifier = (function () {
 		ready: ready,
 		supported: true,
 
-		// set this to true to be able to use simplifyPoints and simplifyWithAttributes
-		// note that these functions are experimental and may change interface/behavior in a way that will require revising calling code
-		useExperimentalFeatures: false,
-
 		compactMesh: function (indices) {
 			assert(
 				indices instanceof Uint32Array || indices instanceof Int32Array || indices instanceof Uint16Array || indices instanceof Int16Array
@@ -234,7 +230,6 @@ var MeshoptSimplifier = (function () {
 			var options = 0;
 			for (var i = 0; i < (flags ? flags.length : 0); ++i) {
 				assert(flags[i] in simplifyOptions);
-				assert(this.useExperimentalFeatures || flags[i] != 'Prune'); // set useExperimentalFeatures to use experimental flags like Prune
 				options |= simplifyOptions[flags[i]];
 			}
 
@@ -267,7 +262,6 @@ var MeshoptSimplifier = (function () {
 			target_error,
 			flags
 		) {
-			assert(this.useExperimentalFeatures); // set useExperimentalFeatures to use this; note that this function is experimental and may change interface in a way that will require revising calling code
 			assert(
 				indices instanceof Uint32Array || indices instanceof Int32Array || indices instanceof Uint16Array || indices instanceof Int16Array
 			);
@@ -330,7 +324,6 @@ var MeshoptSimplifier = (function () {
 		},
 
 		simplifyPoints: function (vertex_positions, vertex_positions_stride, target_vertex_count, vertex_colors, vertex_colors_stride, color_weight) {
-			assert(this.useExperimentalFeatures); // set useExperimentalFeatures to use this; note that this function is experimental and may change interface in a way that will require revising calling code
 			assert(vertex_positions instanceof Float32Array);
 			assert(vertex_positions.length % vertex_positions_stride == 0);
 			assert(vertex_positions_stride >= 3);

js/meshopt_simplifier.module.d.ts

@@ -6,8 +6,6 @@ export const MeshoptSimplifier: {
 	supported: boolean;
 	ready: Promise<void>;
 
-	useExperimentalFeatures: boolean;
-
 	compactMesh: (indices: Uint32Array) => [Uint32Array, number];
 
 	simplify: (
@@ -19,7 +17,6 @@ export const MeshoptSimplifier: {
 		flags?: Flags[]
 	) => [Uint32Array, number];
 
-	// Experimental; requires useExperimentalFeatures to be set to true
 	simplifyWithAttributes: (
 		indices: Uint32Array,
 		vertex_positions: Float32Array,
@@ -35,7 +32,6 @@ export const MeshoptSimplifier: {
 
 	getScale: (vertex_positions: Float32Array, vertex_positions_stride: number) => number;
 
-	// Experimental; requires useExperimentalFeatures to be set to true
 	simplifyPoints: (
 		vertex_positions: Float32Array,
 		vertex_positions_stride: number,

js/meshopt_simplifier.module.js

@@ -204,10 +204,6 @@ var MeshoptSimplifier = (function () {
 		ready: ready,
 		supported: true,
 
-		// set this to true to be able to use simplifyPoints and simplifyWithAttributes
-		// note that these functions are experimental and may change interface/behavior in a way that will require revising calling code
-		useExperimentalFeatures: false,
-
 		compactMesh: function (indices) {
 			assert(
 				indices instanceof Uint32Array || indices instanceof Int32Array || indices instanceof Uint16Array || indices instanceof Int16Array
@@ -233,7 +229,6 @@ var MeshoptSimplifier = (function () {
 			var options = 0;
 			for (var i = 0; i < (flags ? flags.length : 0); ++i) {
 				assert(flags[i] in simplifyOptions);
-				assert(this.useExperimentalFeatures || flags[i] != 'Prune'); // set useExperimentalFeatures to use experimental flags like Prune
 				options |= simplifyOptions[flags[i]];
 			}
 
@@ -266,7 +261,6 @@ var MeshoptSimplifier = (function () {
 			target_error,
 			flags
 		) {
-			assert(this.useExperimentalFeatures); // set useExperimentalFeatures to use this; note that this function is experimental and may change interface in a way that will require revising calling code
 			assert(
 				indices instanceof Uint32Array || indices instanceof Int32Array || indices instanceof Uint16Array || indices instanceof Int16Array
 			);
@@ -329,7 +323,6 @@ var MeshoptSimplifier = (function () {
 		},
 
 		simplifyPoints: function (vertex_positions, vertex_positions_stride, target_vertex_count, vertex_colors, vertex_colors_stride, color_weight) {
-			assert(this.useExperimentalFeatures); // set useExperimentalFeatures to use this; note that this function is experimental and may change interface in a way that will require revising calling code
 			assert(vertex_positions instanceof Float32Array);
 			assert(vertex_positions.length % vertex_positions_stride == 0);
 			assert(vertex_positions_stride >= 3);

js/meshopt_simplifier.test.js

@@ -6,8 +6,6 @@ process.on('unhandledRejection', (error) => {
 	process.exit(1);
 });
 
-simplifier.useExperimentalFeatures = true;
-
 var tests = {
 	compactMesh: function () {
 		var indices = new Uint32Array([0, 1, 3, 3, 1, 5]);