Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zetacored : remove msg type url for events emitted from begin or end block #3335

Open
kingpinXD opened this issue Jan 7, 2025 · 1 comment
Assignees
Labels
code-quality Code quality improvement m:emissions zetacore Issues related to ZetaCore

Comments

@kingpinXD
Copy link
Contributor

The following events are emitted from begin block of emissions module.

message EventObserverEmissions {
  string msg_type_url = 1;
  repeated ObserverEmission emissions = 2;
}
message EventBlockEmissions {
  string msg_type_url = 1;
  string bond_factor = 2;
  string reserves_factor = 3;
  string duration_factor = 4;
  string validator_rewards_for_block = 5;
  string observer_rewards_for_block = 6;
  string tss_rewards_for_block = 7;
}

They currently have a hard-coded value for the field msg_type_url , which should be removed as there is no message associated with these events

@kingpinXD kingpinXD added zetacore Issues related to ZetaCore m:emissions code-quality Code quality improvement labels Jan 7, 2025
@kingpinXD kingpinXD self-assigned this Jan 7, 2025
@kingpinXD
Copy link
Contributor Author

Note : We should verify that this field is not currently being used before removing it completely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-quality Code quality improvement m:emissions zetacore Issues related to ZetaCore
Projects
None yet
Development

No branches or pull requests

1 participant