Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated Sass warnings #117

Open
MarcellavonderWeppen opened this issue Jan 16, 2025 · 0 comments
Open

Deprecated Sass warnings #117

MarcellavonderWeppen opened this issue Jan 16, 2025 · 0 comments

Comments

@MarcellavonderWeppen
Copy link

Hi there,

First of all, thank you for providing this beautiful theme! I've been using it for a project and wanted to let you know about some deprecation warnings that appeared when running jekyll serve locally. These warnings are related to Sass and could potentially cause issues in the future as Dart Sass evolves. Here are the details:


1. Deprecation Warning: @import is deprecated

Sass has deprecated the @import rule and plans to remove it entirely in Dart Sass 3.0.0. This affects the following lines in the file /assets/css/style.scss:

@import "bootstrap/functions";
@import "bootstrap-variables";
@import "bootstrap/variables";
@import "bootstrap/maps";

Suggested Solution: Replace @import with @use. Example:

@use "bootstrap/functions";

You can read more about this in the [official Sass documentation](https://sass-lang.com/d/import).


2. Deprecation Warning: Color Functions (lighten, darken)

Functions like lighten() and darken() are also deprecated. Here's an example from /assets/css/style.scss (line 13):

$link-hover-color: lighten($primary, 10%);

Suggested Solution: Replace these functions with color.adjust or color.scale. Example:

$link-hover-color: color.adjust($primary, $lightness: 10%);

More details can be found in the [color functions documentation](https://sass-lang.com/d/color-functions).


3. Other Deprecations

There are additional warnings related to global built-in functions like mix() and map-merge, as well as red(), green(), and blue(). While they don't currently break functionality, updating them to the latest standards would ensure compatibility with future Sass releases.


What Works

The theme works perfectly fine for now despite these warnings. However, addressing these issues will make the theme future-proof and compliant with Sass best practices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant