Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More tests, more docs #12

Open
fantix opened this issue Jul 2, 2014 · 6 comments
Open

More tests, more docs #12

fantix opened this issue Jul 2, 2014 · 6 comments
Milestone

Comments

@fantix
Copy link
Member

fantix commented Jul 2, 2014

No description provided.

@fantix fantix added this to the v1.0 milestone Jul 2, 2014
@fantix fantix added task and removed task labels Jul 2, 2014
fantix added a commit that referenced this issue Jul 2, 2014
fantix added a commit that referenced this issue Jul 9, 2014
@cjdsellers
Copy link

Hi all,

If I was to get involved with the project - are there any suggestions for where adding unit tests would be most valuable?

@TheButlah
Copy link
Contributor

@cjdsellers integration tests against the reference zeromq implementation would be very valuable - specifically making sure that the library is compliant with the spec.

@cjdsellers
Copy link

Ok understood. I've working with ZMQ before in both C# and Python and integrated services between those languages. I'll familiarize myself with the spec some more.

@Alexei-Kornienko
Copy link
Collaborator

What I'm actually doing when working on some new functionality:

  • Implement this code in Python using official driver.
  • Replace some of the code with Rust equivalent.
  • Replace other parts step by step.

Maybe we could do the same for integrations tests so for example test Rust implementation against some python code (cause it requires only a few lines of code). Need to think about how this can be run locally and on CI. Possibly in a docker container?

@TheButlah
Copy link
Contributor

@Alexei-Kornienko its probably fine to just rely on the zmq crate in our integration tests for now, since that is just a binding for libzmq

@Alexei-Kornienko
Copy link
Collaborator

@TheButlah yeah but still it's a bit harder to setup and configure.. maybe it's faster however for me Python is much easier to bootstrap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants