How to set slowThreshold

[Nanosk07]

In the function below, slowThreshold is used to determine if a call is slow. However, when I try to modify slowThreshold using SetSlowThreshold function, the comment suggests using StatConf instead. StatConf.SlowThreshold is passed into the logDuration function as the durationThreshold parameter. It is only used in the if isSlow(duration, durationThreshold) check, but it does not affect slowThreshold. Does this indicate a bug?

func logDuration(ctx context.Context, method string, req any, duration time.Duration,ignoreMethods *collection.Set, durationThreshold time.Duration) {

      ...

	if !shouldLogContent(method, ignoreMethods) {
		if isSlow(duration, durationThreshold) {
			logger.Slowf("[RPC] slowcall - %s - %s", addr, method)
		}
	} else {
		content, err := json.Marshal(req)
		if err != nil {
			logx.WithContext(ctx).Errorf("%s - %s", addr, err.Error())
		} else if duration > slowThreshold.Load() {
			logger.Slowf("[RPC] slowcall - %s - %s - %s", addr, method, string(content))
		} else {
			logger.Infof("%s - %s - %s", addr, method, string(content))
		}
	}
}



// SetSlowThreshold sets the slow threshold.
// Deprecated: use StatConf instead.
func SetSlowThreshold(threshold time.Duration) {
	slowThreshold.Set(threshold)
}

[kevwan]

Yes, would you please submit a PR? Thanks!

[Nanosk07]

Yes, would you please submit a PR? Thanks!

Hi,
I have submitted a PR #4654 that completely removes all usages of slowThreshold.

I also removed the default value for StatConf.SlowThreshold, allowing users to decide whether to enable slow logs. However, I’m not sure if this aligns with the original design. Please help me confirm. If this change is not appropriate, I will restore the default value.

Thanks!