drivers: watchdog: gecko: Fix timeout period inconsistency with EM1 #86115
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Bluetooth Host
zephyrbot
requested review from
alwa-nordic,
asmellby,
cvinayak,
hermabe,
HoZHel,
jerome-pouiller,
jhedberg,
kartben,
katsuster,
Martinhoff-maker,
nashif,
rugeGerritsen,
sjanc,
Thalley and
theob-pro
adri1mart1
force-pushed
the
wdt-gecko-em1
branch
from
58b9ac7 to
851f814
Compare
jhedberg
changed the title
jhedberg
removed
area: Bluetooth
area: Samples
jerome-pouiller
previously approved these changes
Feb 21, 2025
jhedberg
previously approved these changes
Feb 21, 2025
asmellby
requested changes
Feb 21, 2025
There was a problem hiding this comment.
Upon further inspection: This struct member is not available on all devices supported by the driver. I believe this needs to be guarded by #if defined(_WDOG_CFG_EM1RUN_MASK). The lack of a test failure suggests the driver needs to be built for more platforms in CI.
default watchdog initialization disable counting in EM1, EM2 and EM3 modes. If user use the WDT_OPT_PAUSE_IN_SLEEP flag via the watchdog api, all 3 EM modes must take this flag into account to avoid wdt count being frozen if we don't want to. Signed-off-by: Adrien MARTIN <[email protected]>
adri1mart1
dismissed stale reviews from jhedberg and jerome-pouiller
via
1da4cbf
adri1mart1
force-pushed
the
wdt-gecko-em1
branch
from
851f814 to
1da4cbf
Compare
asmellby
approved these changes
Feb 21, 2025
jhedberg
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default watchdog initialization disable counting in EM1, EM2 and EM3 modes. If user use the WDT_OPT_PAUSE_IN_SLEEP flag via the watchdog api, all 3 EM modes must take this flag into account to avoid wdt count being frozen if we don't want to.
Fixes #86114