scripts: build: check_init_prio: create dedicated "flag errors" function

There is a bit of logic to run every time an error is reported. Factor it
out into a dedicated function.

Signed-off-by: Mathieu Choplain <[email protected]>

Author: mathieuchopstm

scripts/build/check_init_priorities.py

@@ -262,6 +262,17 @@ def __init__(self, elf_file_path, edt_pickle, log, elf_file):
 
         self.errors = 0
 
+    def _flag_error(self, msg):
+        """Remember that a validation error occurred and report to user"""
+        if not self.errors:
+            self.log.error(
+                "Device initialization priority validation failed, "
+                "the sequence of initialization calls does not match "
+                "the devicetree dependencies."
+            )
+        self.errors += 1
+        self.log.error(msg)
+
     def _check_dep(self, dev_ord, dep_ord):
         """Validate the priority between two devices."""
         if dev_ord == dep_ord:
@@ -287,14 +298,7 @@ def _check_dep(self, dev_ord, dep_ord):
                 f"{dev_node.path} and {dep_node.path} have the same priority: {dev_prio}"
             )
         elif dev_prio < dep_prio:
-            if not self.errors:
-                self.log.error(
-                    "Device initialization priority validation failed, "
-                    "the sequence of initialization calls does not match "
-                    "the devicetree dependencies."
-                )
-            self.errors += 1
-            self.log.error(
+            self._flag_error(
                 f"{dev_node.path} <{dev_init}> is initialized before its dependency "
                 f"{dep_node.path} <{dep_init}> ({dev_prio} < {dep_prio})"
             )