feat: add basic vim navigation to urlbar

[adrianord]

Adds the keybinds ctrl+j and ctrl+k to down and up respectively when the urlbar is active for making selections.

This change adds:

• Preference for activating vim navigation for backwards compatibility
• Patch for activating the preference
• IDs in the locales for the preference
  • Localization is all in English, but I am happy to go back and try to translate a few if that helps, just not my strong suit.

Tested on MacOS and Ubuntu (Parallels)

Behavior we see:

• ctrl+j and ctrl+k take precedence when the urlbar is active
• keybinds bound to ctrl+j and ctrl+j still work while the urlbar is not active

zen-urlbar-vim-navigation-1080.mov

[mr-cheffy]

Could there please be some unit tests about this to make sure future firefox versions dont break this functionality?

[adrianord]

@mr-cheffy I've gone ahead and written a unit test for the vim navigation feature.

It's a little crude, so let me know if you have a better way to force multiple possible selections in the URLBar more reliably. What I've done works, but I'm afraid it might be a little brittle, so I'll leave it up to your judgement.

[adrianord]

Rebased to fix conflicts, is there anything else that needs to be done in this PR before it can get reviewed?

[adrianord]

Updated the PR to remove the option from Preferences to keep it just in about:config, removed the localization since that was only used for the Preferences checkbox, and added the test for when the about:config option is turned off.

[adrianord]

Is there anything else that needs to be done to get this feature out?

[adrianord]

I see that a recent zen update upgraded to firefox 143.0.4, so I'm building locally to make sure everything in this PR still works.

[adrianord]

Everything works, ready for re-review

[mr-cheffy]

Im seeing tests are failing, did you give these a try?

[adrianord]

I did a full clean of my repo and rebuild then test and I don't see the test failure. What platform are you running on so I can try to reproduce? I ran the tests today on MacOS 26.0.1 and get one failing test that is unrelated to the PR.

[adrianord]

I was able to reproduce the test failure on Ubuntu, will let you know when it is fixed.

[KennethHoff]

Standard vim key bindings for navigation - assuming j and k (Without modifiers) is unavailable - is ctrl-n and ctrl-p (I assume they stand for next and previous respectively, but not sure about that). ctrl-j and ctrl-k is unorthodox.

[adrianord]

@KennethHoff Huh, I hadn't realized this because I'm so used to using ctrl+j and ctrl+k from my own configuration for so many years. Regardless, I feel like there is a quite a few people who are looking for this either because they use this in their own (neo)vim configuration or because they are coming from Arc where this is standard.

I'll re-think the feature, maybe just give the preference a different name, or dive deeper to make this more configurable.

[yatinlala]

#10753 has added CTRL-n and CTRL-p by default, though its not customizable. Perhaps this PR should be closed.

[adrianord]

Will open another PR once I get around to working on making those keys customizable