Skip to content

Commit e6f6b8f

Browse files
mattpocockmattpocock
committed
Made exercise inherit from tsconfig.json
1 parent 4f9d8bf commit e6f6b8f

File tree

2 files changed

+24
-92
lines changed

2 files changed

+24
-92
lines changed

‎scripts/exercise.js

+16-1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,19 @@ const fs = require("fs");
33
const path = require("path");
44
const chokidar = require("chokidar");
55
const fg = require("fast-glob");
6+
const tsconfig = require("../tsconfig.json");
7+
8+
const compilerOptions = Object.entries(tsconfig.compilerOptions)
9+
.map(([key, value]) => {
10+
if (typeof value === "boolean") {
11+
if (value) {
12+
return `--${key}`;
13+
}
14+
return "";
15+
}
16+
return `--${key} ${value}`;
17+
})
18+
.join(" ");
619

720
const srcPath = path.resolve(__dirname, "../src");
821

@@ -49,7 +62,9 @@ chokidar.watch(exerciseFile).on("all", (event, path) => {
4962
});
5063
}
5164
console.log("Checking types...");
52-
execSync(`tsc "${exerciseFile}" --noEmit --strict --skipLibCheck`, {
65+
const cmd = `tsc "${exerciseFile}" ${compilerOptions}`;
66+
67+
execSync(cmd, {
5368
stdio: "inherit",
5469
});
5570
console.log("Typecheck complete. You finished the exercise!");

‎tsconfig.json

+8-91
Original file line numberDiff line numberDiff line change
@@ -3,98 +3,15 @@
33
"types": [
44
"vitest/importMeta"
55
],
6-
/* Visit https://aka.ms/tsconfig to read more about this file */
7-
/* Projects */
8-
// "incremental": true, /* Save .tsbuildinfo files to allow for incremental compilation of projects. */
9-
// "composite": true, /* Enable constraints that allow a TypeScript project to be used with project references. */
10-
// "tsBuildInfoFile": "./.tsbuildinfo", /* Specify the path to .tsbuildinfo incremental compilation file. */
11-
// "disableSourceOfProjectReferenceRedirect": true, /* Disable preferring source files instead of declaration files when referencing composite projects. */
12-
// "disableSolutionSearching": true, /* Opt a project out of multi-project reference checking when editing. */
13-
// "disableReferencedProjectLoad": true, /* Reduce the number of projects loaded automatically by TypeScript. */
14-
/* Language and Environment */
15-
"target": "es2020", /* Set the JavaScript language version for emitted JavaScript and include compatible library declarations. */
16-
// "lib": [], /* Specify a set of bundled library declaration files that describe the target runtime environment. */
17-
// "jsx": "preserve", /* Specify what JSX code is generated. */
18-
// "experimentalDecorators": true, /* Enable experimental support for TC39 stage 2 draft decorators. */
19-
// "emitDecoratorMetadata": true, /* Emit design-type metadata for decorated declarations in source files. */
20-
// "jsxFactory": "", /* Specify the JSX factory function used when targeting React JSX emit, e.g. 'React.createElement' or 'h'. */
21-
// "jsxFragmentFactory": "", /* Specify the JSX Fragment reference used for fragments when targeting React JSX emit e.g. 'React.Fragment' or 'Fragment'. */
22-
// "jsxImportSource": "", /* Specify module specifier used to import the JSX factory functions when using 'jsx: react-jsx*'. */
23-
// "reactNamespace": "", /* Specify the object invoked for 'createElement'. This only applies when targeting 'react' JSX emit. */
24-
// "noLib": true, /* Disable including any library files, including the default lib.d.ts. */
25-
// "useDefineForClassFields": true, /* Emit ECMAScript-standard-compliant class fields. */
26-
// "moduleDetection": "auto", /* Control what method is used to detect module-format JS files. */
27-
/* Modules */
28-
"module": "ES2022", /* Specify what module code is generated. */
6+
"target": "es2020",
7+
"module": "ES2022",
298
"moduleResolution": "node",
30-
// "rootDir": "./", /* Specify the root folder within your source files. */
31-
// "moduleResolution": "node", /* Specify how TypeScript looks up a file from a given module specifier. */
32-
// "baseUrl": "./", /* Specify the base directory to resolve non-relative module names. */
33-
// "paths": {}, /* Specify a set of entries that re-map imports to additional lookup locations. */
34-
// "rootDirs": [], /* Allow multiple folders to be treated as one when resolving modules. */
35-
// "typeRoots": [], /* Specify multiple folders that act like './node_modules/@types'. */
36-
// "types": [], /* Specify type package names to be included without being referenced in a source file. */
37-
// "allowUmdGlobalAccess": true, /* Allow accessing UMD globals from modules. */
38-
// "moduleSuffixes": [], /* List of file name suffixes to search when resolving a module. */
39-
// "resolveJsonModule": true, /* Enable importing .json files. */
40-
// "noResolve": true, /* Disallow 'import's, 'require's or '<reference>'s from expanding the number of files TypeScript should add to a project. */
41-
/* JavaScript Support */
42-
// "allowJs": true, /* Allow JavaScript files to be a part of your program. Use the 'checkJS' option to get errors from these files. */
43-
// "checkJs": true, /* Enable error reporting in type-checked JavaScript files. */
44-
// "maxNodeModuleJsDepth": 1, /* Specify the maximum folder depth used for checking JavaScript files from 'node_modules'. Only applicable with 'allowJs'. */
45-
/* Emit */
46-
// "declaration": true, /* Generate .d.ts files from TypeScript and JavaScript files in your project. */
47-
// "declarationMap": true, /* Create sourcemaps for d.ts files. */
48-
// "emitDeclarationOnly": true, /* Only output d.ts files and not JavaScript files. */
49-
// "sourceMap": true, /* Create source map files for emitted JavaScript files. */
50-
// "outFile": "./", /* Specify a file that bundles all outputs into one JavaScript file. If 'declaration' is true, also designates a file that bundles all .d.ts output. */
51-
// "outDir": "./", /* Specify an output folder for all emitted files. */
52-
// "removeComments": true, /* Disable emitting comments. */
53-
"noEmit": true, /* Disable emitting files from a compilation. */
54-
// "importHelpers": true, /* Allow importing helper functions from tslib once per project, instead of including them per-file. */
55-
// "importsNotUsedAsValues": "remove", /* Specify emit/checking behavior for imports that are only used for types. */
56-
// "downlevelIteration": true, /* Emit more compliant, but verbose and less performant JavaScript for iteration. */
57-
// "sourceRoot": "", /* Specify the root path for debuggers to find the reference source code. */
58-
// "mapRoot": "", /* Specify the location where debugger should locate map files instead of generated locations. */
59-
// "inlineSourceMap": true, /* Include sourcemap files inside the emitted JavaScript. */
60-
// "inlineSources": true, /* Include source code in the sourcemaps inside the emitted JavaScript. */
61-
// "emitBOM": true, /* Emit a UTF-8 Byte Order Mark (BOM) in the beginning of output files. */
62-
// "newLine": "crlf", /* Set the newline character for emitting files. */
63-
// "stripInternal": true, /* Disable emitting declarations that have '@internal' in their JSDoc comments. */
64-
// "noEmitHelpers": true, /* Disable generating custom helper functions like '__extends' in compiled output. */
65-
// "noEmitOnError": true, /* Disable emitting files if any type checking errors are reported. */
66-
// "preserveConstEnums": true, /* Disable erasing 'const enum' declarations in generated code. */
67-
// "declarationDir": "./", /* Specify the output directory for generated declaration files. */
68-
// "preserveValueImports": true, /* Preserve unused imported values in the JavaScript output that would otherwise be removed. */
69-
/* Interop Constraints */
70-
"isolatedModules": true, /* Ensure that each file can be safely transpiled without relying on other imports. */
71-
// "allowSyntheticDefaultImports": true, /* Allow 'import x from y' when a module doesn't have a default export. */
72-
"esModuleInterop": true, /* Emit additional JavaScript to ease support for importing CommonJS modules. This enables 'allowSyntheticDefaultImports' for type compatibility. */
73-
// "preserveSymlinks": true, /* Disable resolving symlinks to their realpath. This correlates to the same flag in node. */
74-
"forceConsistentCasingInFileNames": true, /* Ensure that casing is correct in imports. */
75-
/* Type Checking */
76-
"strict": true, /* Enable all strict type-checking options. */
77-
// "noImplicitAny": true, /* Enable error reporting for expressions and declarations with an implied 'any' type. */
78-
// "strictNullChecks": true, /* When type checking, take into account 'null' and 'undefined'. */
79-
// "strictFunctionTypes": true, /* When assigning functions, check to ensure parameters and the return values are subtype-compatible. */
80-
// "strictBindCallApply": true, /* Check that the arguments for 'bind', 'call', and 'apply' methods match the original function. */
81-
// "strictPropertyInitialization": true, /* Check for class properties that are declared but not set in the constructor. */
82-
// "noImplicitThis": true, /* Enable error reporting when 'this' is given the type 'any'. */
83-
// "useUnknownInCatchVariables": true, /* Default catch clause variables as 'unknown' instead of 'any'. */
84-
// "alwaysStrict": true, /* Ensure 'use strict' is always emitted. */
85-
// "noUnusedLocals": true, /* Enable error reporting when local variables aren't read. */
86-
// "noUnusedParameters": true, /* Raise an error when a function parameter isn't read. */
87-
// "exactOptionalPropertyTypes": true, /* Interpret optional property types as written, rather than adding 'undefined'. */
88-
// "noImplicitReturns": true, /* Enable error reporting for codepaths that do not explicitly return in a function. */
89-
// "noFallthroughCasesInSwitch": true, /* Enable error reporting for fallthrough cases in switch statements. */
90-
// "noUncheckedIndexedAccess": true, /* Add 'undefined' to a type when accessed using an index. */
91-
// "noImplicitOverride": true, /* Ensure overriding members in derived classes are marked with an override modifier. */
92-
// "noPropertyAccessFromIndexSignature": true, /* Enforces using indexed accessors for keys declared using an indexed type. */
93-
// "allowUnusedLabels": true, /* Disable error reporting for unused labels. */
94-
// "allowUnreachableCode": true, /* Disable error reporting for unreachable code. */
95-
/* Completeness */
96-
// "skipDefaultLibCheck": true, /* Skip type checking .d.ts files that are included with TypeScript. */
97-
"skipLibCheck": true /* Skip type checking all .d.ts files. */
9+
"noEmit": true,
10+
"isolatedModules": true,
11+
"esModuleInterop": true,
12+
"forceConsistentCasingInFileNames": true,
13+
"strict": true,
14+
"skipLibCheck": true
9815
},
9916
"include": [
10017
"src"

0 commit comments

Comments
 (0)