[BugFix] Fix DeleteMgr use Read Lock in the scope of IS Lock bug (StarRocks#48784)

Signed-off-by: HangyuanLiu <[email protected]>

Author: HangyuanLiu

fe/fe-core/src/main/java/com/starrocks/common/util/concurrent/lock/LockType.java

@@ -65,6 +65,19 @@ public boolean isConflict(LockType requestedType) {
         return !CONFLICT_MATRIX[id][requestedType.id];
     }
 
+    public boolean isIntentionLock() throws NotSupportLockException {
+        switch (id) {
+            case 0:
+            case 1:
+                return false;
+            case 2:
+            case 3:
+                return true;
+        }
+
+        throw new NotSupportLockException("Lock Internal Error");
+    }
+
     @Override
     public String toString() {
         if (id == 0) {

fe/fe-core/src/main/java/com/starrocks/common/util/concurrent/lock/MultiUserLock.java

@@ -103,10 +103,12 @@ private LockGrantType tryLock(LockHolder lockHolderRequest) throws LockException
                      * The outer layer has already obtained the intention lock,
                      * and the inner layer code should not apply for read-write locks.
                      */
-                    if ((lockOwnerLockType == LockType.INTENTION_SHARED || lockOwnerLockType == LockType.INTENTION_EXCLUSIVE)
-                            && (lockRequestLockType == LockType.READ || lockRequestLockType == LockType.WRITE)) {
-                        throw new NotSupportLockException("Can't request " + lockRequestLockType
-                                + " in the scope of " + lockOwnerLockType + ", " + lockOwner.getLocker().getLockerStackTrace());
+
+                    if (lockOwnerLockType.isIntentionLock() && !lockRequestLockType.isIntentionLock()) {
+                        throw new NotSupportLockException("Can't request Database " + lockRequestLockType + " Lock ("
+                                + lockHolderRequest.getLocker().getLockerStackTrace() + ")"
+                                + " in the scope of Database " + lockOwnerLockType
+                                + "Lock (" + lockOwner.getLocker().getLockerStackTrace() + ")");
                     }
 
                     /*

fe/fe-core/src/main/java/com/starrocks/load/DeleteMgr.java

@@ -190,7 +190,7 @@ public void process(DeleteStmt stmt) throws DdlException, QueryStateException {
         try {
             List<Partition> partitions = Lists.newArrayList();
             Locker locker = new Locker();
-            locker.lockTablesWithIntensiveDbLock(db, Lists.newArrayList(table.getId()), LockType.READ);
+            locker.lockDatabase(db, LockType.READ);
             try {
                 if (!table.isOlapOrCloudNativeTable()) {
                     throw new DdlException("Delete is not supported on " + table.getType() + " table");
@@ -212,7 +212,7 @@ public void process(DeleteStmt stmt) throws DdlException, QueryStateException {
                 }
                 throw new DdlException(t.getMessage(), t);
             } finally {
-                locker.unLockTablesWithIntensiveDbLock(db, Lists.newArrayList(table.getId()), LockType.READ);
+                locker.unLockDatabase(db, LockType.READ);
             }
 
             deleteJob.run(stmt, db, table, partitions);