[Refactor] Remove code of cachelib (StarRocks#48859)

cachelib is useless now, so remove it.

Signed-off-by: trueeyu <[email protected]>

Author: trueeyu

be/CMakeLists.txt

@@ -82,8 +82,6 @@ option(WITH_GCOV "Build binary with gcov to get code coverage" OFF)
 
 option(WITH_COMPRESS "Build binary with compresss debug section" ON)
 
-option(WITH_CACHELIB "Build binary with cachelib library" OFF)
-
 option(WITH_STARCACHE "Build binary with starcache library" ON)
 option(WITH_BRCP_KEEPALIVE "Build binary with brpc_socket_keepalive (requires brpc 1.8)" OFF)
 
@@ -412,45 +410,6 @@ if (${WITH_TENANN} STREQUAL "ON")
     endif()
 endif()
 
-# cachelib
-set(CACHELIB_DEPENDENCIES
-    cachelib_common
-    cachelib_allocator
-    cachelib_datatype
-    cachelib_navy
-    cachelib_shm
-    folly
-    fmtd
-    thriftcpp2
-    thrift-core
-    thriftmetadata
-    thriftfrozen2
-    thriftprotocol
-    thrifttype
-    transport
-    rpcmetadata
-    thriftanyrep
-    thrifttyperep
-    thriftannotation
-    concurrency
-    async
-    wangle
-)
-
-if (${WITH_CACHELIB} STREQUAL "ON")
-    LINK_LIBRARIES(${THIRDPARTY_DIR}/cachelib/deps/lib64/libunwind.so)
-    LINK_LIBRARIES(${THIRDPARTY_DIR}/cachelib/deps/lib64/liblzma.so)
-    foreach(dep ${CACHELIB_DEPENDENCIES})
-        add_library(${dep} STATIC IMPORTED)
-        set(location "${THIRDPARTY_DIR}/cachelib/lib/lib${dep}.a")
-        if(NOT EXISTS ${location})
-            set(location "${THIRDPARTY_DIR}/cachelib/lib64/lib${dep}.a")
-        endif()
-        set_target_properties(${dep} PROPERTIES IMPORTED_LOCATION "${location}")
-        message(STATUS "add cachelib dependency: ${location}")
-    endforeach()
-endif()
-
 if (${WITH_STARCACHE} STREQUAL "ON")
     add_library(starcache STATIC IMPORTED GLOBAL)
     set(STARCACHE_DIR "${THIRDPARTY_DIR}/starcache")
@@ -665,9 +624,6 @@ set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -Werror=return-type -Werror=switch")
 if (${USE_STAROS} STREQUAL "ON")
     set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -DUSE_STAROS")
 endif()
-if (${WITH_CACHELIB} STREQUAL "ON")
-    set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -DWITH_CACHELIB")
-endif()
 if (${WITH_STARCACHE} STREQUAL "ON")
     set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -DWITH_STARCACHE")
 endif()
@@ -936,16 +892,6 @@ set(STARROCKS_DEPENDENCIES
     ${WL_END_GROUP}
 )
 
-if (${WITH_CACHELIB} STREQUAL "ON")
-    set(STARROCKS_DEPENDENCIES
-        ${STARROCKS_DEPENDENCIES}
-        ${WL_START_GROUP}
-        ${Boost_LIBRARIES}
-        ${CACHELIB_DEPENDENCIES}
-        ${WL_END_GROUP}
-    )
-endif()
-
 if (${WITH_STARCACHE} STREQUAL "ON")
     set(STARROCKS_DEPENDENCIES
         ${STARROCKS_DEPENDENCIES}

be/src/bench/block_cache_bench.cpp

@@ -32,9 +32,6 @@
 #include "util/logging.h"
 #include "util/random.h"
 #include "util/time.h"
-#ifdef WITH_CACHELIB
-#include "block_cache/cachelib_wrapper.h"
-#endif
 
 namespace starrocks {
 
@@ -50,12 +47,9 @@ void delete_dir_content(const std::string& dir_path) {
     }
 }
 
-enum class CacheEngine { CACHELIB, STARCACHE };
-
 class BlockCacheBenchSuite {
 public:
     struct BenchParams {
-        CacheEngine cache_engine;
         size_t obj_count = 0;
         size_t obj_key_size = 0;
         size_t obj_value_size = 0;
@@ -115,16 +109,7 @@ class BlockCacheBenchSuite {
 
     BlockCacheBenchSuite(const CacheOptions& options, const BenchParams& params) {
         _params = new BlockCacheBenchSuite::BenchParams(params);
-        if (params.cache_engine == CacheEngine::STARCACHE) {
-            _cache = new StarCacheWrapper;
-#ifdef WITH_CACHELIB
-        } else {
-            _cache = new CacheLibWrapper;
-#endif
-        }
-        else {
-            DCHECK(false) << "Unsupported cache engine: " << params.cache_engine;
-        }
+        _cache = new StarCacheWrapper;
         Status st = _cache->init(options);
         DCHECK(st.ok()) << st.message();
         _ctx = new BenchContext();
@@ -283,17 +268,9 @@ static void do_bench_cache(benchmark::State& state, const CacheOptions& options,
     //state.counters["read_throught"] = suite->ctx()->read_throught->get_value();
 }
 
-template <class... Args>
-static void BM_bench_cachelib(benchmark::State& state, Args&&... args) {
-    auto args_tuple = std::make_tuple(std::move(args)...);
-    std::get<0>(args_tuple).second.cache_engine = CacheEngine::CACHELIB;
-    do_bench_cache(state, std::get<0>(args_tuple).first, std::get<0>(args_tuple).second);
-}
-
 template <class... Args>
 static void BM_bench_starcache(benchmark::State& state, Args&&... args) {
     auto args_tuple = std::make_tuple(std::move(args)...);
-    std::get<0>(args_tuple).second.cache_engine = CacheEngine::STARCACHE;
     do_bench_cache(state, std::get<0>(args_tuple).first, std::get<0>(args_tuple).second);
 }
 
@@ -391,13 +368,6 @@ BENCHMARK_CAPTURE(BM_bench_starcache, bench_read_write_remove_disk, read_write_r
 // Random offset for Read+Write+Remove Disk
 BENCHMARK_CAPTURE(BM_bench_starcache, bench_random_offset_read, random_offset_read_suite())->Threads(16);
 
-#ifdef WITH_CACHELIB
-BENCHMARK_CAPTURE(BM_bench_cachelib, bench_read_mem, read_mem_suite())->Threads(16);
-BENCHMARK_CAPTURE(BM_bench_cachelib, bench_read_disk, read_disk_suite())->Threads(16);
-BENCHMARK_CAPTURE(BM_bench_cachelib, bench_read_write_remove_disk, read_write_remove_disk_suite())->Threads(16);
-BENCHMARK_CAPTURE(BM_bench_cachelib, bench_random_offset_read, random_offset_read_suite())->Threads(16);
-#endif
-
 } // namespace starrocks
 
 //BENCHMARK_MAIN();

be/src/block_cache/CMakeLists.txt

@@ -31,23 +31,10 @@ set(CACHE_FILES
   block_cache_hit_rate_counter.hpp
 )
 
-if (${WITH_CACHELIB} STREQUAL "ON")
-    list(APPEND CACHE_FILES cachelib_wrapper.cpp)
-endif()
-
 if (${WITH_STARCACHE} STREQUAL "ON")
     list(APPEND CACHE_FILES starcache_wrapper.cpp)
 endif()
 
 add_library(BlockCache STATIC
     ${CACHE_FILES}
 )
-
-if (${WITH_CACHELIB} STREQUAL "ON")
-    set(CACHELIB_DIR ${THIRDPARTY_DIR}/cachelib)
-    link_directories(${CACHELIB_DIR}/deps/lib64)
-
-    include_directories(AFTER ${CACHELIB_DIR}/include)
-    include_directories(AFTER ${CACHELIB_DIR}/deps/include)
-endif()
-

be/src/block_cache/block_cache.cpp

@@ -16,15 +16,9 @@
 
 #include <fmt/format.h>
 
-#include <filesystem>
-
-#ifdef WITH_CACHELIB
-#include "block_cache/cachelib_wrapper.h"
-#endif
 #ifdef WITH_STARCACHE
 #include "block_cache/starcache_wrapper.h"
 #endif
-#include "common/config.h"
 #include "common/logging.h"
 #include "common/statusor.h"
 #include "gutil/strings/substitute.h"
@@ -33,8 +27,6 @@ namespace starrocks {
 
 namespace fs = std::filesystem;
 
-// The cachelib doesn't support a item (key+valueu+attribute) larger than 4 MB without chain.
-// So, we check and limit the block_size configured by users to avoid unexpected errors.
 // For starcache, in theory we doesn't have a hard limitation for block size, but a very large
 // block_size may cause heavy read amplification. So, we also limit it to 2 MB as an empirical value.
 const size_t BlockCache::MAX_BLOCK_SIZE = 2 * 1024 * 1024;
@@ -51,12 +43,6 @@ BlockCache::~BlockCache() {
 Status BlockCache::init(const CacheOptions& options) {
     _block_size = std::min(options.block_size, MAX_BLOCK_SIZE);
     auto cache_options = options;
-#ifdef WITH_CACHELIB
-    if (cache_options.engine == "cachelib") {
-        _kv_cache = std::make_unique<CacheLibWrapper>();
-        LOG(INFO) << "init cachelib engine, block_size: " << _block_size;
-    }
-#endif
 #ifdef WITH_STARCACHE
     if (cache_options.engine == "starcache") {
         _kv_cache = std::make_unique<StarCacheWrapper>();