Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Printer feedback #56

Open
benmccann opened this issue Aug 23, 2017 · 0 comments
Open

Printer feedback #56

benmccann opened this issue Aug 23, 2017 · 0 comments

Comments

@benmccann
Copy link
Contributor

Why does the method below take a Supplier<String>? It seems like String would be sufficient

public Printer<T> withNullValue(Supplier<String> nullValue) {

Also, Formats.registerPrinters calls .withNullValue(nullValue) on every single printer, which doesn't seem like it should be necessary since DEFAULT_NULL has the same value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benmccann