Skip to content

Commit 4ea793d

Browse files
kindjacketjoshmoore
kindjacket
andauthored
c-blosc upgrade 1.18.1 -> 1.21.0 (#283)
* c-blosc upgrade to 1.18.1 -> 1.21.0 * change from master to v1.21.0 * remove HAVE_SNAPPY macro to fix c-blosc build * Disable snappy tests * Remove snappy fixture * Enter blank into codecs tests to preserve indexes * Revert "Remove snappy fixture" This reverts commit a84a166. Co-authored-by: Josh Moore <[email protected]> Co-authored-by: jmoore <[email protected]>
1 parent 9eac7b1 commit 4ea793d

File tree

4 files changed

+15
-4
lines changed

4 files changed

+15
-4
lines changed

c-blosc

Submodule c-blosc updated 164 files

numcodecs/tests/common.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -261,6 +261,9 @@ def check_backwards_compatibility(codec_id, arrays, codecs, precision=None, pref
261261

262262
for j, codec in enumerate(codecs):
263263

264+
if codec is None:
265+
pytest.skip("codec has been removed")
266+
264267
# setup a directory to hold encoded data
265268
codec_dir = os.path.join(fixture_dir, 'codec.{:02d}'.format(j))
266269
if not os.path.exists(codec_dir): # pragma: no cover

numcodecs/tests/test_blosc.py

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
Blosc(cname='zlib', clevel=1, shuffle=0),
3535
Blosc(cname='zstd', clevel=1, shuffle=1),
3636
Blosc(cname='blosclz', clevel=1, shuffle=2),
37-
Blosc(cname='snappy', clevel=1, shuffle=2),
37+
None, # was snappy
3838
Blosc(shuffle=Blosc.SHUFFLE, blocksize=0),
3939
Blosc(shuffle=Blosc.SHUFFLE, blocksize=2**8),
4040
Blosc(cname='lz4', clevel=1, shuffle=Blosc.NOSHUFFLE, blocksize=2**8),
@@ -61,6 +61,11 @@
6161
]
6262

6363

64+
def _skip_null(codec):
65+
if codec is None:
66+
pytest.skip("codec has been removed")
67+
68+
6469
@pytest.fixture(scope='module', params=[True, False, None])
6570
def use_threads(request):
6671
return request.param
@@ -69,6 +74,7 @@ def use_threads(request):
6974
@pytest.mark.parametrize('array', arrays)
7075
@pytest.mark.parametrize('codec', codecs)
7176
def test_encode_decode(array, codec):
77+
_skip_null(codec)
7278
check_encode_decode(array, codec)
7379

7480

@@ -77,6 +83,7 @@ def test_encode_decode(array, codec):
7783
else pytest.param(x, marks=[pytest.mark.xfail])
7884
for x in arrays])
7985
def test_partial_decode(codec, array):
86+
_skip_null(codec)
8087
check_encode_decode_partial(array, codec)
8188

8289

@@ -143,7 +150,6 @@ def test_compress_complib(use_threads):
143150
'lz4': 'LZ4',
144151
'lz4hc': 'LZ4',
145152
'blosclz': 'BloscLZ',
146-
'snappy': 'Snappy',
147153
'zlib': 'Zlib',
148154
'zstd': 'Zstd',
149155
}
@@ -257,6 +263,7 @@ def test_err_encode_object_buffer():
257263

258264
def test_decompression_error_handling():
259265
for codec in codecs:
266+
_skip_null(codec)
260267
with pytest.raises(RuntimeError):
261268
codec.decode(bytearray())
262269
with pytest.raises(RuntimeError):
@@ -265,5 +272,6 @@ def test_decompression_error_handling():
265272

266273
def test_max_buffer_size():
267274
for codec in codecs:
275+
_skip_null(codec)
268276
assert codec.max_buffer_size == 2**31 - 1
269277
check_max_buffer_size(codec)

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ def blosc_extension():
7979
include_dirs += [d for d in glob('c-blosc/internal-complibs/*/*/*')
8080
if os.path.isdir(d)]
8181
define_macros += [('HAVE_LZ4', 1),
82-
('HAVE_SNAPPY', 1),
82+
# ('HAVE_SNAPPY', 1),
8383
('HAVE_ZLIB', 1),
8484
('HAVE_ZSTD', 1)]
8585
# define_macros += [('CYTHON_TRACE', '1')]

0 commit comments

Comments
 (0)