Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move cmd/common to cmd #3184

Open
mkcp opened this issue Nov 4, 2024 · 1 comment
Open

chore: move cmd/common to cmd #3184

mkcp opened this issue Nov 4, 2024 · 1 comment

Comments

@mkcp
Copy link
Contributor

mkcp commented Nov 4, 2024

Describe what should be investigated or refactored

Right now the cmd package subpackage cmd/common containing shared functionality. Packages with overly-general names like common, utils, etc. are generally discouraged. We can make the system more maintainable by lifting the common package up into cmd and, if necessary, moving specific functionality to subpackages named after what hey provide. (viper.go looks like a good candidate for this).

Links to any relevant code

https://github.com/zarf-dev/zarf/tree/main/src/cmd/common

Additional context

Blocked by #3183, #2773

@mkcp
Copy link
Contributor Author

mkcp commented Nov 4, 2024

Blocked by #3183, #2773

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Triage
Development

No branches or pull requests

2 participants