Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kustomize components: changes are not triggering kubechecks run #351

Open
andridzi opened this issue Jan 8, 2025 · 3 comments
Open

Kustomize components: changes are not triggering kubechecks run #351

andridzi opened this issue Jan 8, 2025 · 3 comments

Comments

@andridzi
Copy link
Contributor

andridzi commented Jan 8, 2025

I think it's missing here

Will be nice to have!

@djeebus
Copy link
Collaborator

djeebus commented Jan 9, 2025

Thanks for finding what was going on and where to sort it out! Easily done. Mind testing the PR once it's built, see if it sorts out your problem?

@andridzi
Copy link
Contributor Author

hello @djeebus, I was to test this fix, but had to upgrade from v1.8.1 and having some troubles with ArgoCD repo server, in particular it looks like KUBECHECKS_ARGOCD_SEND_FULL_REPOSITORY set to true is not taking into account as I still see
packaging app INFO message instead of sending full repository.

Is there a chance that the code contains a bug (I wasn't able to find it without building/testing own image) or I am doing smth wrong?

thanks in advance!

@andridzi
Copy link
Contributor Author

@djeebus, I've successfully tested this and confirm it works, thanks a lot!

regarding KUBECHECKS_ARGOCD_SEND_FULL_REPOSITORY env, after some testing I realised that it works only with flag, like this:

deployment:
  args:
    - "./kubechecks"
    - "controller"
    - "--argocd-send-full-repository"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants