Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FlakyTest TestPrometheusMetrics #3072

Open
MustafaSaber opened this issue May 8, 2024 · 1 comment
Open

FlakyTest TestPrometheusMetrics #3072

MustafaSaber opened this issue May 8, 2024 · 1 comment
Labels
flakytest

Comments

@MustafaSaber
Copy link
Member

https://github.com/zalando/skipper/actions/runs/9004582619/job/24737898384?pr=3059

--- FAIL: TestPrometheusMetrics (0.06s)
    --- FAIL: TestPrometheusMetrics/Measuring_all_serves_by_the_hosts_split_by_hosts,_only_should_measure_served_latency_by_route_without_method_and_code. (0.01s)
        prometheus_test.go:1049: 'skipper_serve_host_duration_seconds_sum{host="host1"} 0.015' metric not present on the result of metrics service
FAIL
FAIL	github.com/zalando/skipper/metrics	0.407s
@AlexanderYastrebov
Copy link
Member

Likely test checks metrics before they updated. We can add a small delay to mitigate if this reappears.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flakytest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AlexanderYastrebov @MustafaSaber