Skip to content

Commit 2698395

Browse files
committed
cleaning up examples
1 parent 60d5d5d commit 2698395

File tree

5 files changed

+3
-38
lines changed

5 files changed

+3
-38
lines changed

README.md

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -48,20 +48,6 @@ foreach($data as $row)
4848
$writer->writeToFile('example.xlsx');
4949
```
5050

51-
Set document properties:
52-
```php
53-
$keywords = array('some','interesting','keywords');
54-
55-
$writer = new XLSXWriter();
56-
57-
$writer->setTitle('Some Title');
58-
$writer->setSubject('Some Subject');
59-
$writer->setAuthor('Some Author');
60-
$writer->setCompany('Some Company');
61-
$writer->setKeywords($keywords);
62-
$writer->setDescription('Some interesting description');
63-
```
64-
6551
50000 rows: (1.4s, 0MB memory usage)
6652
```php
6753
include_once("xlsxwriter.class.php");

example-cli.php

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,8 @@
1111
array('2003','=B1', '23.5','2010-01-01 00:00:00','2012-12-31 00:00:00'),
1212
);
1313

14-
$keywords = array('some','interesting','keywords');
15-
1614
$writer = new XLSXWriter();
17-
$writer->setTitle('Some Title');
18-
$writer->setSubject('Some Subject');
19-
$writer->setAuthor('Some Author');
20-
$writer->setCompany('Some Company');
21-
$writer->setKeywords($keywords);
22-
$writer->setDescription('Some interesting description');
15+
$writer->setAuthor('Some Author');
2316
foreach($rows as $row)
2417
$writer->writeSheetRow('Sheet1', $row);
2518

example.php

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16,15 +16,8 @@
1616
array('2003','=B1', '23.5','2010-01-01 00:00:00','2012-12-31 00:00:00'),
1717
);
1818

19-
$keywords = array('some','interesting','keywords');
20-
2119
$writer = new XLSXWriter();
22-
$writer->setTitle('Some Title');
23-
$writer->setSubject('Some Subject');
24-
$writer->setAuthor('Some Author');
25-
$writer->setCompany('Some Company');
26-
$writer->setKeywords($keywords);
27-
$writer->setDescription('Some interesting description');
20+
$writer->setAuthor('Some Author');
2821
foreach($rows as $row)
2922
$writer->writeSheetRow('Sheet1', $row);
3023
$writer->writeToStdOut();

examples/ex02-formats.php

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -40,15 +40,8 @@
4040
$date = '2018-12-31 23:59:59';
4141
$amount = '5120.5';
4242

43-
$keywords = array('some','interesting','keywords');
44-
4543
$writer = new XLSXWriter();
46-
$writer->setTitle('Some Title');
47-
$writer->setSubject('Some Subject');
4844
$writer->setAuthor('Some Author');
49-
$writer->setCompany('Some Company');
50-
$writer->setKeywords($keywords);
51-
$writer->setDescription('Some interesting description');
5245
$writer->writeSheetHeader('BasicFormats',$sheet1header);
5346
$writer->writeSheetRow('BasicFormats',array($pi,$pi,$pi,$pi,$pi,$pi,$pi,$pi,$pi) );
5447
$writer->writeSheetHeader('Dates',$sheet2header);

xlsxwriter.class.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -587,7 +587,7 @@ protected function buildCoreXML()
587587
$core_xml.='<dc:subject>'.self::xmlspecialchars($this->subject).'</dc:subject>';
588588
$core_xml.='<dc:creator>'.self::xmlspecialchars($this->author).'</dc:creator>';
589589
if (!empty($this->keywords)) {
590-
$core_xml.='<cp:keywords>'.self::xmlspecialchars(implode (", ", $this->keywords)).'</cp:keywords>';
590+
$core_xml.='<cp:keywords>'.self::xmlspecialchars(implode (", ", (array)$this->keywords)).'</cp:keywords>';
591591
}
592592
$core_xml.='<dc:description>'.self::xmlspecialchars($this->description).'</dc:description>';
593593
$core_xml.='<cp:revision>0</cp:revision>';

0 commit comments

Comments
 (0)