update tarballs in support to load_sample #103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 3, 2021
|
N00b question: why aren't we fixing |
|
Well my reasoning is that load_sample is very hard to properly test in CI and it's already filled with magic (i.e. special casing that feel pretty brittle). What I'm trying to accomplish is to have the function do one thing and do it well, instead of breaking apart in every way possible. |
neutrinoceros
changed the title
neutrinoceros
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #101
Most of the fix is to repackage tarballs, so here are the new ones:
note that in most cases I changed the extraction directory to match the tarball name (in some cases I added a directory layer), but in one case I instead renamed the dataset to match the existing extraction directory (
A2052->xray_fits), because I find that we might as well use the more descriptive name as a key since it already exists.I'll open a companion PR on the main repo's side to reflect this change and update the hashes. (update: this is yt-project/yt#3334)
This PR exhausts the list of improperly formed tarballs, it will not be necessary to open new ones in the future