Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: add baseline.model argument to summary() #381

Open
uhkeller opened this issue Aug 30, 2024 · 4 comments
Open

Feature request: add baseline.model argument to summary() #381

uhkeller opened this issue Aug 30, 2024 · 4 comments

Comments

@uhkeller
Copy link

As of version 0.6-18, fitMeasures() takes a baseline.model argument to adjust the computation of GFI et al., but summary() does not. It is thus not possible to obtain the correct comparison-based fit measures in the summary output if a custom baseline model is needed. As far as I can tell, the baseline model could just be passed from lav_object_summary() to lav_fit_measures().

@yrosseel
Copy link
Owner

yrosseel commented Sep 3, 2024

I will look into it. But I don't want to add another argument to summary(). It will go into the fm.args() argument, which collects everything related to fit measures. This requires a little bit more work, as baseline.model is not part of fm.args() in fitMeasures()...

@TDJorgensen
Copy link
Contributor

Yves, I had an idea about this. Just as the standardized= argument can now be a character string (and the old FALSE implies an empty string), the fit.measures= argument could now be a list() of arguments (besides fm.args=) that get passed to fitMeasures(). TRUE or FALSE implies an empty list.

I can work on a PR if you like this idea.

@TDJorgensen
Copy link
Contributor

Same idea with passing args to modIndices() via the summary(modindices=) argument, BTW.

@yrosseel
Copy link
Owner

yrosseel commented Sep 4, 2024

Ok, that sounds good. I suppose that we would have to remove the fm.args= argument (in the summary() method) (perhaps after a deprecation period)? All that information could go in the 'list()' for fit.measures. Or would you keep the fm.args= argument?

And indeed, we could do this for modindices= too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants