-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: add baseline.model argument to summary() #381
Comments
I will look into it. But I don't want to add another argument to summary(). It will go into the fm.args() argument, which collects everything related to fit measures. This requires a little bit more work, as baseline.model is not part of fm.args() in fitMeasures()... |
Yves, I had an idea about this. Just as the I can work on a PR if you like this idea. |
Same idea with passing args to |
Ok, that sounds good. I suppose that we would have to remove the fm.args= argument (in the summary() method) (perhaps after a deprecation period)? All that information could go in the 'list()' for fit.measures. Or would you keep the fm.args= argument? And indeed, we could do this for modindices= too. |
As of version 0.6-18,
fitMeasures()
takes abaseline.model
argument to adjust the computation of GFI et al., butsummary()
does not. It is thus not possible to obtain the correct comparison-based fit measures in the summary output if a custom baseline model is needed. As far as I can tell, the baseline model could just be passed fromlav_object_summary()
tolav_fit_measures()
.The text was updated successfully, but these errors were encountered: