fix(Picker): should reset the second argument when the first argument… #13366
Conversation
… is changed somehow
… is changed somehow
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13366 +/- ##
==========================================
+ Coverage 89.60% 89.71% +0.11%
==========================================
Files 257 257
Lines 7013 7021 +8
Branches 1736 1738 +2
==========================================
+ Hits 6284 6299 +15
+ Misses 384 382 -2
+ Partials 345 340 -5 ☔ View full report in Codecov by Sentry. |
|
@inottn Please help to review. I done and fixed all fail tests . |
| if (isEmptyOption !== AREA_EMPTY_CODE) { | ||
| setValue(index, isEmptyOption); | ||
| } |
There was a problem hiding this comment.
The logic of Area should not be mixed into the Picker, as it may affect users who use the Picker.
There was a problem hiding this comment.
@inottn
Is there a method to distinguish this data from Area's columnsPlaceholder?
I suppose we could add a mark when executIng theformatDataForCascade function.
{
"text: "City",
"value": "000000",
"children":[],
"isPlaceholder": true
}
|
I don't know if the previous interactions were intentional; if there is an issue, the onChange logic might need to be modified. If I have time, I will see how to adjust it. |
I definitely sure that it wasn't intentional. and it is a bug. |
… is changed somehow
fixes: #13365
we should reset the second argument when the first argument is changed.
Before submitting a pull request, please read the contributing guide.
在提交 pull request 之前，请阅读 贡献指南。