rustc_resolve: remove unneeded returns

yotamofek · yotamofek · commit 38169d6d4819 · 2025-01-20T17:34:18.000Z
diff --git a/compiler/rustc_resolve/src/diagnostics.rs b/compiler/rustc_resolve/src/diagnostics.rs
@@ -3048,7 +3048,6 @@ impl<'tcx> visit::Visitor<'tcx> for UsePlacementFinder {
                 self.first_legal_span = Some(inject);
             }
             self.first_use_span = search_for_any_use_in_items(&c.items);
-            return;
         } else {
             visit::walk_crate(self, c);
         }
@@ -3062,7 +3061,6 @@ impl<'tcx> visit::Visitor<'tcx> for UsePlacementFinder {
                     self.first_legal_span = Some(inject);
                 }
                 self.first_use_span = search_for_any_use_in_items(items);
-                return;
             }
         } else {
             visit::walk_item(self, item);

Original file line number	Diff line number	Diff line change
`@@ -3048,7 +3048,6 @@ impl<'tcx> visit::Visitor<'tcx> for UsePlacementFinder {`
`3048`	`3048`	`self.first_legal_span = Some(inject);`
`3049`	`3049`	`}`
`3050`	`3050`	`self.first_use_span = search_for_any_use_in_items(&c.items);`
`3051`		`- return;`
`3052`	`3051`	`} else {`
`3053`	`3052`	`visit::walk_crate(self, c);`
`3054`	`3053`	`}`
`@@ -3062,7 +3061,6 @@ impl<'tcx> visit::Visitor<'tcx> for UsePlacementFinder {`
`3062`	`3061`	`self.first_legal_span = Some(inject);`
`3063`	`3062`	`}`
`3064`	`3063`	`self.first_use_span = search_for_any_use_in_items(items);`
`3065`		`- return;`
`3066`	`3064`	`}`
`3067`	`3065`	`} else {`
`3068`	`3066`	`visit::walk_item(self, item);`