Skip to content

yklua doesn't drop locations. #113

@vext01

Description

@vext01

yklua doesn't use yk_location_drop() at all at the moment, so locations are leaked.

This would be less of a concern if we only leaked locations created statically by the parser, but the Lua interpreter has this tendency to dynamically dump/undump functions (bypassing the parser entirely). During dumping we lose references to locations, and during undumping we create fresh locations, which in turn go on to leak.

Depending on the program being executed, this dump+undump can happen quite a bit.

A side-question I don't know the answer to is: what happens if you drop a location that the JIT is using (e.g. tracing, compiling, ...).

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions