From 16a4c211a0caf5c9663c21c675d088adfeb255de Mon Sep 17 00:00:00 2001 From: Edd Barrett Date: Mon, 4 Aug 2025 16:18:24 +0100 Subject: [PATCH] Convert a todo! to a FIXME in the trace optimiser. This scenario can indeed happen. I've just seen it with the Lua tests with the "really long trace" fix that's pending to merge. --- ykrt/src/compile/jitc_yk/opt/analyse.rs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ykrt/src/compile/jitc_yk/opt/analyse.rs b/ykrt/src/compile/jitc_yk/opt/analyse.rs index 716dc3c99..489b6ab67 100644 --- a/ykrt/src/compile/jitc_yk/opt/analyse.rs +++ b/ykrt/src/compile/jitc_yk/opt/analyse.rs @@ -69,8 +69,7 @@ impl Analyse { if let (&Operand::Const(_lhs_cidx), &Operand::Const(_rhs_cidx)) = (&lhs, &rhs) { - // Can we still hit this case? - todo!(); + // FIXME: implement the optimisation. } } op