Enable new secrets by default (#26914)

Author: yurikiselev

ydb/core/kqp/ut/scheme/kqp_scheme_ut.cpp

@@ -13723,33 +13723,31 @@ END DO)",
         }
     }
 
-    Y_UNIT_TEST(SecretsDisabled) {
-        const auto settings = TKikimrSettings()
-            .SetWithSampleTables(false);
-        TKikimrRunner kikimr(settings);
+    Y_UNIT_TEST(SecretsEnabledByDefault) {
+        TKikimrRunner kikimr;
         auto db = kikimr.GetTableClient();
         auto session = db.CreateSession().GetValueSync().GetSession();
 
         { // create
             static const auto query = R"sql(
-                CREATE SECRET `/Root/secret-name` WITH (value = "secret-value");
+                CREATE SECRET `/Root/secret-name-1` WITH (value = "secret-value");
             )sql";
             const auto result = session.ExecuteSchemeQuery(query).GetValueSync();
-            UNIT_ASSERT_VALUES_EQUAL_C(result.GetStatus(), EStatus::INTERNAL_ERROR, result.GetIssues().ToString());
+            UNIT_ASSERT_VALUES_EQUAL_C(result.GetStatus(), EStatus::SUCCESS, result.GetIssues().ToString());
         }
         { // alter
             static const auto query = R"sql(
-                ALTER SECRET `/Root/secret-name` WITH (value = "secret-value");
+                ALTER SECRET `/Root/secret-name-1` WITH (value = "secret-value");
             )sql";
             const auto result = session.ExecuteSchemeQuery(query).GetValueSync();
-            UNIT_ASSERT_VALUES_EQUAL_C(result.GetStatus(), EStatus::INTERNAL_ERROR, result.GetIssues().ToString());
+            UNIT_ASSERT_VALUES_EQUAL_C(result.GetStatus(), EStatus::SUCCESS, result.GetIssues().ToString());
         }
         { // drop
             static const auto query = R"sql(
-                DROP SECRET `/Root/secret-name`;
+                DROP SECRET `/Root/secret-name-1`;
             )sql";
             const auto result = session.ExecuteSchemeQuery(query).GetValueSync();
-            UNIT_ASSERT_VALUES_EQUAL_C(result.GetStatus(), EStatus::INTERNAL_ERROR, result.GetIssues().ToString());
+            UNIT_ASSERT_VALUES_EQUAL_C(result.GetStatus(), EStatus::SUCCESS, result.GetIssues().ToString());
         }
     }
 }

ydb/core/protos/feature_flags.proto

@@ -226,7 +226,7 @@ message TFeatureFlags {
     optional bool EnableMirroredTopicSplitMerge = 200 [default = false];
     optional bool EnableFulltextIndex = 201 [default = false];
     optional bool EnableSetColumnConstraint = 202 [default = false];
-    optional bool EnableSchemaSecrets = 203 [default = false];
+    optional bool EnableSchemaSecrets = 203 [default = true];
     optional bool EnableTableCacheModes = 204 [default = false];
     optional bool EnableSkipMessagesWithObsoleteTimestamp = 205 [default = false];
     optional bool EnableStreamingQueries = 206 [default = false];